From: Eric Wong <normalperson@yhbt.net>
To: Benoit SIGOURE <tsuna@lrde.epita.fr>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] Add a generic tree traversal to fetch SVN properties.
Date: Tue, 16 Oct 2007 02:55:03 -0700 [thread overview]
Message-ID: <20071016095503.GB30503@soma> (raw)
In-Reply-To: <07B09A42-73DD-4565-975F-A4E40BF862AC@lrde.epita.fr>
Benoit SIGOURE <tsuna@lrde.epita.fr> wrote:
> On Oct 16, 2007, at 9:43 AM, Eric Wong wrote:
>
> >Benoit Sigoure <tsuna@lrde.epita.fr> wrote:
> >> * git-svn.perl (&traverse_ignore): Remove.
> >> (&prop_walk): New.
> >> (&cmd_show_ignore): Use prop_walk.
> >>
> >>Signed-off-by: Benoit Sigoure <tsuna@lrde.epita.fr>
> >
> >Although I myself have never needed this functionality, this series
> >looks pretty good in general.
>
> I heavily script Git with my own wrappers and having this sort if
> functionality does enhance the scriptability of git-svn.
Ah. I've actually wanted something like `svn info` or `git-svn
rev-parse` myself for a while, but haven't gotten to implementing it
myself, either. Something that could easily give me the current URL of
a repo, or the URL of any path in a repo
$ git svn info --remote-url local/path.c
=> https://example.com/svn/trunk/local/path.c
$ git svn info --url
=> https://example.com/svn/trunk
I think there was other functionality that I've wanted in the past
but have forgotten at the moment. I need to sleep, badly :x
> >Thanks.
>
> You're welcome :)
>
> >
> >One comment below about property selection (whitelist vs blacklist).
> >
> >
> >It would be possible to get identical information out of
> >unhandled.log,
> >but older repositories may not have complete information... Maybe
> >some
> >local option would be good for people with complete unhandled.log
> >files;
> >but it could be really incomplete/insufficient.
> >
>
> In order to avoid using SVN::Ra and avoid access to the SVN repo?
> Hmm, clever, I didn't think about this. Maybe we can provide both,
> the default would check unhandled.log and an option would enable
> direct access to the SVN repo?
Yes. I'm alright with the direct SVN repo code for now, and we can do
unhandled.log later since it's more things to do.
> >Coding style
> >
> >Other than that, I prefer to keep braces on the same line as foreach,
> >if, else statements. I generally follow the git and Linux coding
> >style for C in my Perl code.
> >
> >One exception that I make for Perl (but not C) is that I keep the "{"
> >for subs on the same line (since subs can be nested and anonymous ones
> >passed as arguments and such); unlike their C counterparts[1]
>
> Indeed, sorry, I started correctly but then completely forgot to
> follow the existing Coding Style. The CS I use daily is totally
> different, sorry ;)
> Shall I resend the patch series with corrected CS?
Yes, please. Thanks.
--
Eric Wong
prev parent reply other threads:[~2007-10-16 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 15:35 [PATCH 1/5] Add a generic tree traversal to fetch SVN properties Benoit Sigoure
2007-10-15 15:35 ` [PATCH 2/5] Implement git svn create-ignore Benoit Sigoure
2007-10-15 15:35 ` [PATCH 3/5] Add git svn propget Benoit Sigoure
2007-10-15 15:35 ` [PATCH 4/5] Add git svn proplist Benoit Sigoure
2007-10-15 15:35 ` [PATCH 5/5] Simplify the handling of fatal errors Benoit Sigoure
2007-10-16 7:43 ` [PATCH 1/5] Add a generic tree traversal to fetch SVN properties Eric Wong
2007-10-16 9:35 ` Benoit SIGOURE
2007-10-16 9:55 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016095503.GB30503@soma \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=tsuna@lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).