* [StGit PATCH 0/5] Make push and refresh subdirectory safe
@ 2007-10-07 23:24 Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 1/5] Infrastructure for current directory handling Karl Hasselström
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Karl Hasselström @ 2007-10-07 23:24 UTC (permalink / raw
To: Catalin Marinas; +Cc: git
This series makes push and refresh safe to use from subdirectories, by
using the infrastructure of the first patch to cd to the top of the
worktree.
As stated in the commit messages, this may not be an optimal long-term
solution, but we need to fix this quick. And the infrastructure isn't
good only for cd'ing to the top of the worktree.
This series is also available from
git://repo.or.cz/stgit/kha.git safe
---
Karl Hasselström (5):
Make "stg refresh" subdirectory safe
New test: try "stg refresh" in a subdirectory
Make "stg push" subdirectory safe
New test: Try "stg push" in a subdirectory
Infrastructure for current directory handling
stgit/commands/add.py | 1 +
stgit/commands/applied.py | 1 +
stgit/commands/assimilate.py | 1 +
stgit/commands/branch.py | 1 +
stgit/commands/clean.py | 1 +
stgit/commands/clone.py | 1 +
stgit/commands/commit.py | 1 +
stgit/commands/common.py | 68 ++++++++++++++++++++++++++++++++++++++++++
stgit/commands/copy.py | 1 +
stgit/commands/delete.py | 1 +
stgit/commands/diff.py | 1 +
stgit/commands/edit.py | 1 +
stgit/commands/export.py | 1 +
stgit/commands/files.py | 1 +
stgit/commands/float.py | 1 +
stgit/commands/fold.py | 1 +
stgit/commands/goto.py | 1 +
stgit/commands/hide.py | 1 +
stgit/commands/id.py | 1 +
stgit/commands/imprt.py | 1 +
stgit/commands/init.py | 1 +
stgit/commands/log.py | 1 +
stgit/commands/mail.py | 1 +
stgit/commands/new.py | 1 +
stgit/commands/patches.py | 1 +
stgit/commands/pick.py | 1 +
stgit/commands/pop.py | 1 +
stgit/commands/pull.py | 1 +
stgit/commands/push.py | 1 +
stgit/commands/rebase.py | 1 +
stgit/commands/refresh.py | 1 +
stgit/commands/rename.py | 1 +
stgit/commands/resolved.py | 1 +
stgit/commands/rm.py | 1 +
stgit/commands/series.py | 1 +
stgit/commands/show.py | 1 +
stgit/commands/sink.py | 1 +
stgit/commands/status.py | 1 +
stgit/commands/sync.py | 1 +
stgit/commands/top.py | 1 +
stgit/commands/unapplied.py | 1 +
stgit/commands/uncommit.py | 1 +
stgit/commands/unhide.py | 1 +
stgit/main.py | 2 +
t/t1205-push-subdir.sh | 55 ++++++++++++++++++++++++++++++++++
t/t2300-refresh-subdir.sh | 27 +++++++++++++++++
46 files changed, 194 insertions(+), 0 deletions(-)
create mode 100755 t/t1205-push-subdir.sh
create mode 100755 t/t2300-refresh-subdir.sh
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
^ permalink raw reply [flat|nested] 6+ messages in thread
* [StGit PATCH 1/5] Infrastructure for current directory handling
2007-10-07 23:24 [StGit PATCH 0/5] Make push and refresh subdirectory safe Karl Hasselström
@ 2007-10-07 23:24 ` Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 2/5] New test: Try "stg push" in a subdirectory Karl Hasselström
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Karl Hasselström @ 2007-10-07 23:24 UTC (permalink / raw
To: Catalin Marinas; +Cc: git
Add infrastructure to allow commands to specify if they need a git
repository, if they need to be called from within the working tree,
and if they should cd to the root of the working tree before doing
anything else.
For now, all commands are set to just require a repository (except
"stg clone", which is set to require nothing), which means the only
thing that's added is some very light error checking. The idea is to
tighten this for commands that turn out to need it.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
stgit/commands/add.py | 1 +
stgit/commands/applied.py | 1 +
stgit/commands/assimilate.py | 1 +
stgit/commands/branch.py | 1 +
stgit/commands/clean.py | 1 +
stgit/commands/clone.py | 1 +
stgit/commands/commit.py | 1 +
stgit/commands/common.py | 68 ++++++++++++++++++++++++++++++++++++++++++
stgit/commands/copy.py | 1 +
stgit/commands/delete.py | 1 +
stgit/commands/diff.py | 1 +
stgit/commands/edit.py | 1 +
stgit/commands/export.py | 1 +
stgit/commands/files.py | 1 +
stgit/commands/float.py | 1 +
stgit/commands/fold.py | 1 +
stgit/commands/goto.py | 1 +
stgit/commands/hide.py | 1 +
stgit/commands/id.py | 1 +
stgit/commands/imprt.py | 1 +
stgit/commands/init.py | 1 +
stgit/commands/log.py | 1 +
stgit/commands/mail.py | 1 +
stgit/commands/new.py | 1 +
stgit/commands/patches.py | 1 +
stgit/commands/pick.py | 1 +
stgit/commands/pop.py | 1 +
stgit/commands/pull.py | 1 +
stgit/commands/push.py | 1 +
stgit/commands/rebase.py | 1 +
stgit/commands/refresh.py | 1 +
stgit/commands/rename.py | 1 +
stgit/commands/resolved.py | 1 +
stgit/commands/rm.py | 1 +
stgit/commands/series.py | 1 +
stgit/commands/show.py | 1 +
stgit/commands/sink.py | 1 +
stgit/commands/status.py | 1 +
stgit/commands/sync.py | 1 +
stgit/commands/top.py | 1 +
stgit/commands/unapplied.py | 1 +
stgit/commands/uncommit.py | 1 +
stgit/commands/unhide.py | 1 +
stgit/main.py | 2 +
44 files changed, 112 insertions(+), 0 deletions(-)
diff --git a/stgit/commands/add.py b/stgit/commands/add.py
index fc9c5a7..264ab9f 100644
--- a/stgit/commands/add.py
+++ b/stgit/commands/add.py
@@ -31,6 +31,7 @@ Add the files or directories passed as arguments to the
repository. When a directory name is given, all the files and
subdirectories are recursively added."""
+directory = DirectoryHasRepository()
options = []
diff --git a/stgit/commands/applied.py b/stgit/commands/applied.py
index b9bb716..45d0926 100644
--- a/stgit/commands/applied.py
+++ b/stgit/commands/applied.py
@@ -32,6 +32,7 @@ List the patches from the series which were already pushed onto the
stack. They are listed in the order in which they were pushed, the
last one being the current (topmost) patch."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one'),
make_option('-c', '--count',
diff --git a/stgit/commands/assimilate.py b/stgit/commands/assimilate.py
index 43672fd..db8a95c 100644
--- a/stgit/commands/assimilate.py
+++ b/stgit/commands/assimilate.py
@@ -53,6 +53,7 @@ Note that these are "inconsistencies", not "errors"; furthermore,
with the way "assimilate" handles them, you have no reason to avoid
causing them in the first place if that is convenient for you."""
+directory = DirectoryHasRepository()
options = []
class Commit(object):
diff --git a/stgit/commands/branch.py b/stgit/commands/branch.py
index c16fc69..6e0a6d8 100644
--- a/stgit/commands/branch.py
+++ b/stgit/commands/branch.py
@@ -40,6 +40,7 @@ When displaying the branches, the names can be prefixed with
If not given any options, switch to the named branch."""
+directory = DirectoryHasRepository()
options = [make_option('-c', '--create',
help = 'create a new development branch',
action = 'store_true'),
diff --git a/stgit/commands/clean.py b/stgit/commands/clean.py
index 2e3b202..d8bbe71 100644
--- a/stgit/commands/clean.py
+++ b/stgit/commands/clean.py
@@ -31,6 +31,7 @@ Delete the empty patches in the whole series or only those applied or
unapplied. A patch is considered empty if the two commit objects
representing its boundaries refer to the same tree object."""
+directory = DirectoryHasRepository()
options = [make_option('-a', '--applied',
help = 'delete the empty applied patches',
action = 'store_true'),
diff --git a/stgit/commands/clone.py b/stgit/commands/clone.py
index 15139c8..a150010 100644
--- a/stgit/commands/clone.py
+++ b/stgit/commands/clone.py
@@ -29,6 +29,7 @@ usage = """%prog [options] <repository> <dir>
Clone a GIT <repository> into the local <dir> and initialise the
patch stack."""
+directory = DirectoryAnywhere()
options = []
diff --git a/stgit/commands/commit.py b/stgit/commands/commit.py
index 0b76c56..2b45c0d 100644
--- a/stgit/commands/commit.py
+++ b/stgit/commands/commit.py
@@ -32,6 +32,7 @@ remove them from the series while advancing the base.
Use this command only if you want to permanently store the applied
patches and no longer manage them with StGIT."""
+directory = DirectoryHasRepository()
options = []
diff --git a/stgit/commands/common.py b/stgit/commands/common.py
index 9815400..27ef465 100644
--- a/stgit/commands/common.py
+++ b/stgit/commands/common.py
@@ -24,6 +24,7 @@ from optparse import OptionParser, make_option
from stgit.exception import *
from stgit.utils import *
from stgit.out import *
+from stgit.run import *
from stgit import stack, git, basedir
from stgit.config import config, file_extensions
@@ -480,3 +481,70 @@ def parse_patch(fobj):
# we don't yet have an agreed place for the creation date.
# Just return None
return (descr, authname, authemail, authdate, diff)
+
+def readonly_constant_property(f):
+ """Decorator that converts a function that computes a value to an
+ attribute that returns the value. The value is computed only once,
+ the first time it is accessed."""
+ def new_f(self):
+ n = '__' + f.__name__
+ if not hasattr(self, n):
+ setattr(self, n, f(self))
+ return getattr(self, n)
+ return property(new_f)
+
+class DirectoryException(StgException):
+ pass
+
+class _Directory(object):
+ @readonly_constant_property
+ def git_dir(self):
+ try:
+ return Run('git-rev-parse', '--git-dir'
+ ).discard_stderr().output_one_line()
+ except RunException:
+ raise DirectoryException('No git repository found')
+ @readonly_constant_property
+ def __topdir_path(self):
+ try:
+ lines = Run('git-rev-parse', '--show-cdup'
+ ).discard_stderr().output_lines()
+ if len(lines) == 0:
+ return '.'
+ elif len(lines) == 1:
+ return lines[0]
+ else:
+ raise RunException('Too much output')
+ except RunException:
+ raise DirectoryException('No git repository found')
+ @readonly_constant_property
+ def is_inside_git_dir(self):
+ return { 'true': True, 'false': False
+ }[Run('git-rev-parse', '--is-inside-git-dir'
+ ).output_one_line()]
+ @readonly_constant_property
+ def is_inside_worktree(self):
+ return { 'true': True, 'false': False
+ }[Run('git-rev-parse', '--is-inside-work-tree'
+ ).output_one_line()]
+ def cd_to_topdir(self):
+ os.chdir(self.__topdir_path)
+
+class DirectoryAnywhere(_Directory):
+ def setup(self):
+ pass
+
+class DirectoryHasRepository(_Directory):
+ def setup(self):
+ self.git_dir # might throw an exception
+
+class DirectoryInWorktree(DirectoryHasRepository):
+ def setup(self):
+ DirectoryHasRepository.setup(self)
+ if not self.is_inside_worktree:
+ raise DirectoryException('Not inside a git worktree')
+
+class DirectoryGotoToplevel(DirectoryInWorktree):
+ def setup(self):
+ DirectoryInWorktree.setup(self)
+ self.cd_to_topdir()
diff --git a/stgit/commands/copy.py b/stgit/commands/copy.py
index 76e3bf9..e94dd66 100644
--- a/stgit/commands/copy.py
+++ b/stgit/commands/copy.py
@@ -30,6 +30,7 @@ usage = """%prog [options] [<file/dir> <newname> | <files/dirs...> <dir>]
Copy of the files and dirs passed as arguments under another name or
location inside the same repository."""
+directory = DirectoryHasRepository()
options = []
def func(parser, options, args):
diff --git a/stgit/commands/delete.py b/stgit/commands/delete.py
index 2121015..8462857 100644
--- a/stgit/commands/delete.py
+++ b/stgit/commands/delete.py
@@ -36,6 +36,7 @@ patches are deleted, they are popped from the stack.
Note that the 'delete' operation is irreversible."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one')]
diff --git a/stgit/commands/diff.py b/stgit/commands/diff.py
index aeca4ab..f3b0ea2 100644
--- a/stgit/commands/diff.py
+++ b/stgit/commands/diff.py
@@ -42,6 +42,7 @@ rev = '([patch][//[bottom | top]]) | <tree-ish> | base'
If neither bottom nor top are given but a '//' is present, the command
shows the specified patch (defaulting to the current one)."""
+directory = DirectoryHasRepository()
options = [make_option('-r', '--range',
metavar = 'rev1[..[rev2]]', dest = 'revs',
help = 'show the diff between revisions'),
diff --git a/stgit/commands/edit.py b/stgit/commands/edit.py
index 223c628..02970bc 100644
--- a/stgit/commands/edit.py
+++ b/stgit/commands/edit.py
@@ -57,6 +57,7 @@ rejected patch is stored in the .stgit-failed.patch file (and also in
these files using the '--file' and '--diff' options.
"""
+directory = DirectoryHasRepository()
options = [make_option('-d', '--diff',
help = 'edit the patch diff',
action = 'store_true'),
diff --git a/stgit/commands/export.py b/stgit/commands/export.py
index 62be394..d8ce86d 100644
--- a/stgit/commands/export.py
+++ b/stgit/commands/export.py
@@ -49,6 +49,7 @@ file:
%(commemail)s - committer's e-mail
"""
+directory = DirectoryHasRepository()
options = [make_option('-d', '--dir',
help = 'export patches to DIR instead of the default'),
make_option('-p', '--patch',
diff --git a/stgit/commands/files.py b/stgit/commands/files.py
index 1a10023..07cc955 100644
--- a/stgit/commands/files.py
+++ b/stgit/commands/files.py
@@ -34,6 +34,7 @@ given patch. Note that this command doesn't show the files modified in
the working tree and not yet included in the patch by a 'refresh'
command. Use the 'diff' or 'status' commands for these files."""
+directory = DirectoryHasRepository()
options = [make_option('-s', '--stat',
help = 'show the diff stat',
action = 'store_true'),
diff --git a/stgit/commands/float.py b/stgit/commands/float.py
index 0e32f6b..d5299fb 100644
--- a/stgit/commands/float.py
+++ b/stgit/commands/float.py
@@ -31,6 +31,7 @@ necessary pop and push operations will be performed to accomplish
this. The '--series' option can be used to rearrange the (top) patches
as specified by the given series file (or the standard input)."""
+directory = DirectoryHasRepository()
options = [make_option('-s', '--series',
help = 'rearrange according to a series file',
action = 'store_true')]
diff --git a/stgit/commands/fold.py b/stgit/commands/fold.py
index d97185e..6e43101 100644
--- a/stgit/commands/fold.py
+++ b/stgit/commands/fold.py
@@ -34,6 +34,7 @@ performed with the current top. With the --base option, the patch is
applied onto the specified base and a three-way merged is performed
with the current top."""
+directory = DirectoryHasRepository()
options = [make_option('-t', '--threeway',
help = 'perform a three-way merge with the current patch',
action = 'store_true'),
diff --git a/stgit/commands/goto.py b/stgit/commands/goto.py
index a4427fa..9e008a9 100644
--- a/stgit/commands/goto.py
+++ b/stgit/commands/goto.py
@@ -31,6 +31,7 @@ line becomes current. This is a shortcut for the 'push --to' or 'pop
--to' commands. There is no '--undo' option for 'goto'. Use the 'push'
command for this."""
+directory = DirectoryHasRepository()
options = [make_option('-k', '--keep',
help = 'keep the local changes when popping patches',
action = 'store_true')]
diff --git a/stgit/commands/hide.py b/stgit/commands/hide.py
index de19c19..1a38907 100644
--- a/stgit/commands/hide.py
+++ b/stgit/commands/hide.py
@@ -30,6 +30,7 @@ usage = """%prog [options] <patch-range>
Hide a range of unapplied patches so that they are no longer shown in
the plain 'series' command output."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one')]
diff --git a/stgit/commands/id.py b/stgit/commands/id.py
index f72d2f3..3e28f2f 100644
--- a/stgit/commands/id.py
+++ b/stgit/commands/id.py
@@ -33,6 +33,7 @@ the standard GIT id's like heads and tags, this command also accepts
'top' or 'bottom' are passed and <patch> is a valid patch name, 'top'
will be used by default."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one')]
diff --git a/stgit/commands/imprt.py b/stgit/commands/imprt.py
index 717f373..045f185 100644
--- a/stgit/commands/imprt.py
+++ b/stgit/commands/imprt.py
@@ -44,6 +44,7 @@ stack.
The patch description has to be separated from the data with a '---'
line."""
+directory = DirectoryHasRepository()
options = [make_option('-m', '--mail',
help = 'import the patch from a standard e-mail file',
action = 'store_true'),
diff --git a/stgit/commands/init.py b/stgit/commands/init.py
index 46562d0..475a4ce 100644
--- a/stgit/commands/init.py
+++ b/stgit/commands/init.py
@@ -31,6 +31,7 @@ Initialise the current GIT branch to be used as an StGIT stack. Note
that you must already be in a GIT repository and .git/HEAD must point
to a valid file in refs/heads/."""
+directory = DirectoryHasRepository()
options = []
diff --git a/stgit/commands/log.py b/stgit/commands/log.py
index 4d6b022..f8337f9 100644
--- a/stgit/commands/log.py
+++ b/stgit/commands/log.py
@@ -43,6 +43,7 @@ represent the changes to the entire base of the current
patch. Conflicts reset the patch content and a subsequent 'refresh'
will show the entire patch."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one'),
make_option('-p', '--patch',
diff --git a/stgit/commands/mail.py b/stgit/commands/mail.py
index c32894e..4a4158a 100644
--- a/stgit/commands/mail.py
+++ b/stgit/commands/mail.py
@@ -88,6 +88,7 @@ the following:
%(prefix)s - 'prefix ' string passed on the command line
%(shortdescr)s - the first line of the patch description"""
+directory = DirectoryHasRepository()
options = [make_option('-a', '--all',
help = 'e-mail all the applied patches',
action = 'store_true'),
diff --git a/stgit/commands/new.py b/stgit/commands/new.py
index 59671ab..ccc8141 100644
--- a/stgit/commands/new.py
+++ b/stgit/commands/new.py
@@ -38,6 +38,7 @@ needed for this.
If no name is given for the new patch, one is generated from the first
line of the commit message."""
+directory = DirectoryHasRepository()
options = [make_option('-m', '--message',
help = 'use MESSAGE as the patch description'),
make_option('-s', '--showpatch',
diff --git a/stgit/commands/patches.py b/stgit/commands/patches.py
index fb65b62..0b618fe 100644
--- a/stgit/commands/patches.py
+++ b/stgit/commands/patches.py
@@ -33,6 +33,7 @@ it shows the patches affected by the local tree modifications. The
'--diff' option also lists the patch log and the diff for the given
files."""
+directory = DirectoryHasRepository()
options = [make_option('-d', '--diff',
help = 'show the diff for the given files',
action = 'store_true'),
diff --git a/stgit/commands/pick.py b/stgit/commands/pick.py
index 1c3ef11..3acec32 100644
--- a/stgit/commands/pick.py
+++ b/stgit/commands/pick.py
@@ -34,6 +34,7 @@ the name of the current patch. It can be overridden with the '--name'
option. A commit object can be reverted with the '--reverse'
option. The log and author information are those of the commit object."""
+directory = DirectoryHasRepository()
options = [make_option('-n', '--name',
help = 'use NAME as the patch name'),
make_option('-r', '--reverse',
diff --git a/stgit/commands/pop.py b/stgit/commands/pop.py
index 0dfaad9..a1d73e4 100644
--- a/stgit/commands/pop.py
+++ b/stgit/commands/pop.py
@@ -36,6 +36,7 @@ patches passed on the command line are popped from the stack. Some of
the push operations may fail because of conflicts (push --undo would
revert the last push operation)."""
+directory = DirectoryHasRepository()
options = [make_option('-a', '--all',
help = 'pop all the applied patches',
action = 'store_true'),
diff --git a/stgit/commands/pull.py b/stgit/commands/pull.py
index 237bdd9..5fcf2cc 100644
--- a/stgit/commands/pull.py
+++ b/stgit/commands/pull.py
@@ -38,6 +38,7 @@ resolved and the patch pushed again.
Check the 'git fetch' documentation for the <repository> format."""
+directory = DirectoryHasRepository()
options = [make_option('-n', '--nopush',
help = 'do not push the patches back after pulling',
action = 'store_true'),
diff --git a/stgit/commands/push.py b/stgit/commands/push.py
index 53cdb8f..b91bc5e 100644
--- a/stgit/commands/push.py
+++ b/stgit/commands/push.py
@@ -39,6 +39,7 @@ command run.
The command also notifies when the patch becomes empty (fully merged
upstream) or is modified (three-way merged) by the 'push' operation."""
+directory = DirectoryHasRepository()
options = [make_option('-a', '--all',
help = 'push all the unapplied patches',
action = 'store_true'),
diff --git a/stgit/commands/rebase.py b/stgit/commands/rebase.py
index 513729a..bbb3e12 100644
--- a/stgit/commands/rebase.py
+++ b/stgit/commands/rebase.py
@@ -29,6 +29,7 @@ usage = """%prog [options] <new-base-id>
Pop all patches from current stack, move the stack base to the given
<new-base-id> and push the patches back."""
+directory = DirectoryHasRepository()
options = [make_option('-n', '--nopush',
help = 'do not push the patches back after rebasing',
action = 'store_true'),
diff --git a/stgit/commands/refresh.py b/stgit/commands/refresh.py
index 241f065..b283892 100644
--- a/stgit/commands/refresh.py
+++ b/stgit/commands/refresh.py
@@ -37,6 +37,7 @@ options. The '--force' option is useful when a commit object was
created with a different tool but the changes need to be included in
the current patch."""
+directory = DirectoryHasRepository()
options = [make_option('-f', '--force',
help = 'force the refresh even if HEAD and '\
'top differ',
diff --git a/stgit/commands/rename.py b/stgit/commands/rename.py
index 2830e72..e2b0fa4 100644
--- a/stgit/commands/rename.py
+++ b/stgit/commands/rename.py
@@ -29,6 +29,7 @@ usage = """%prog [options] <oldpatch> <newpatch>
Rename <oldpatch> into <newpatch> in a series."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one')]
diff --git a/stgit/commands/resolved.py b/stgit/commands/resolved.py
index 1130641..c2ef678 100644
--- a/stgit/commands/resolved.py
+++ b/stgit/commands/resolved.py
@@ -34,6 +34,7 @@ Mark a merge conflict as resolved. The conflicts can be seen with the
'C'. This command also removes any <file>.{ancestor,current,patched}
files."""
+directory = DirectoryHasRepository()
options = [make_option('-a', '--all',
help = 'mark all conflicts as solved',
action = 'store_true'),
diff --git a/stgit/commands/rm.py b/stgit/commands/rm.py
index 91908a1..59d098b 100644
--- a/stgit/commands/rm.py
+++ b/stgit/commands/rm.py
@@ -30,6 +30,7 @@ usage = """%prog [options] <files...>
Remove given files from the repository. The command doesn't remove the
working copy of the file."""
+directory = DirectoryHasRepository()
options = [make_option('-f', '--force',
help = 'force removing even if the file exists',
action = 'store_true')]
diff --git a/stgit/commands/series.py b/stgit/commands/series.py
index 00a3372..2c75876 100644
--- a/stgit/commands/series.py
+++ b/stgit/commands/series.py
@@ -34,6 +34,7 @@ range. The applied patches are prefixed with a '+', the unapplied ones
with a '-' and the hidden ones with a '!'. The current patch is
prefixed with a '>'. Empty patches are prefixed with a '0'."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one'),
make_option('-a', '--all',
diff --git a/stgit/commands/show.py b/stgit/commands/show.py
index 45ca253..7efb4e1 100644
--- a/stgit/commands/show.py
+++ b/stgit/commands/show.py
@@ -30,6 +30,7 @@ Show the commit log and the diff corresponding to the given
patches. The output is similar to that generated by the 'git show'
command."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one'),
make_option('-a', '--applied',
diff --git a/stgit/commands/sink.py b/stgit/commands/sink.py
index 2a18ebc..737dde0 100644
--- a/stgit/commands/sink.py
+++ b/stgit/commands/sink.py
@@ -32,6 +32,7 @@ push the specified <patches> (the current patch by default), and
then push back into place the formerly-applied patches (unless -n
is also given)."""
+directory = DirectoryHasRepository()
options = [make_option('-n', '--nopush',
help = 'do not push the patches back after sinking',
action = 'store_true'),
diff --git a/stgit/commands/status.py b/stgit/commands/status.py
index b2835ab..a688f7e 100644
--- a/stgit/commands/status.py
+++ b/stgit/commands/status.py
@@ -40,6 +40,7 @@ under revision control. The files are prefixed as follows:
A 'refresh' command clears the status of the modified, new and deleted
files."""
+directory = DirectoryHasRepository()
options = [make_option('-m', '--modified',
help = 'show modified files only',
action = 'store_true'),
diff --git a/stgit/commands/sync.py b/stgit/commands/sync.py
index 580b5bd..8a31c29 100644
--- a/stgit/commands/sync.py
+++ b/stgit/commands/sync.py
@@ -36,6 +36,7 @@ in the series must apply cleanly.
The sync operation can be reverted for individual patches with --undo."""
+directory = DirectoryHasRepository()
options = [make_option('-a', '--all',
help = 'synchronise all the patches',
action = 'store_true'),
diff --git a/stgit/commands/top.py b/stgit/commands/top.py
index 1a9267a..e7cb275 100644
--- a/stgit/commands/top.py
+++ b/stgit/commands/top.py
@@ -30,6 +30,7 @@ usage = """%prog [options]
Print the name of the current (topmost) patch."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one')]
diff --git a/stgit/commands/unapplied.py b/stgit/commands/unapplied.py
index c6408a3..d5bb43e 100644
--- a/stgit/commands/unapplied.py
+++ b/stgit/commands/unapplied.py
@@ -31,6 +31,7 @@ usage = """%prog [options]
List the patches from the series which are not pushed onto the stack.
They are listed in the reverse order in which they were popped."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one'),
make_option('-c', '--count',
diff --git a/stgit/commands/uncommit.py b/stgit/commands/uncommit.py
index c22d3ea..a23ae20 100644
--- a/stgit/commands/uncommit.py
+++ b/stgit/commands/uncommit.py
@@ -48,6 +48,7 @@ given commit should be uncommitted.
Only commits with exactly one parent can be uncommitted; in other
words, you can't uncommit a merge."""
+directory = DirectoryHasRepository()
options = [make_option('-n', '--number', type = 'int',
help = 'uncommit the specified number of commits'),
make_option('-t', '--to',
diff --git a/stgit/commands/unhide.py b/stgit/commands/unhide.py
index 0a1dcaf..665d664 100644
--- a/stgit/commands/unhide.py
+++ b/stgit/commands/unhide.py
@@ -30,6 +30,7 @@ usage = """%prog [options] <patch-range>
Unhide a hidden range of patches so that they are shown in the plain
'series' command output."""
+directory = DirectoryHasRepository()
options = [make_option('-b', '--branch',
help = 'use BRANCH instead of the default one')]
diff --git a/stgit/main.py b/stgit/main.py
index 19ba2bd..15582dd 100644
--- a/stgit/main.py
+++ b/stgit/main.py
@@ -252,6 +252,7 @@ def main():
usage = command.usage.split('\n')[0].strip()
parser = OptionParser(usage = usage, option_list = command.options)
options, args = parser.parse_args()
+ directory = command.directory
# These modules are only used from this point onwards and do not
# need to be imported earlier
@@ -267,6 +268,7 @@ def main():
sys.exit(1)
try:
+ directory.setup()
config_setup()
# 'clone' doesn't expect an already initialised GIT tree. A Series
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [StGit PATCH 2/5] New test: Try "stg push" in a subdirectory
2007-10-07 23:24 [StGit PATCH 0/5] Make push and refresh subdirectory safe Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 1/5] Infrastructure for current directory handling Karl Hasselström
@ 2007-10-07 23:24 ` Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 3/5] Make "stg push" subdirectory safe Karl Hasselström
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Karl Hasselström @ 2007-10-07 23:24 UTC (permalink / raw
To: Catalin Marinas; +Cc: git
This currently fails for the non-fast-forward cases.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
t/t1205-push-subdir.sh | 55 ++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 55 insertions(+), 0 deletions(-)
create mode 100755 t/t1205-push-subdir.sh
diff --git a/t/t1205-push-subdir.sh b/t/t1205-push-subdir.sh
new file mode 100755
index 0000000..6502c20
--- /dev/null
+++ b/t/t1205-push-subdir.sh
@@ -0,0 +1,55 @@
+#!/bin/sh
+test_description='Test the push command from a subdirectory'
+. ./test-lib.sh
+stg init
+
+test_expect_success 'Create some patches' '
+ mkdir foo
+ for i in 0 1 2; do
+ stg new p$i -m p$i &&
+ echo x$i >> x.txt &&
+ echo y$i >> foo/y.txt &&
+ stg add x.txt foo/y.txt &&
+ stg refresh
+ done &&
+ [ "$(echo $(stg applied))" = "p0 p1 p2" ] &&
+ [ "$(echo $(stg unapplied))" = "" ]
+'
+
+test_expect_success 'Fast-forward push from a subdir' '
+ stg pop &&
+ [ "$(echo $(cat x.txt))" = "x0 x1" ] &&
+ [ "$(echo $(cat foo/y.txt))" = "y0 y1" ] &&
+ cd foo &&
+ stg push &&
+ cd .. &&
+ [ "$(echo $(cat x.txt))" = "x0 x1 x2" ] &&
+ [ "$(echo $(cat foo/y.txt))" = "y0 y1 y2" ]
+'
+
+test_expect_failure 'Modifying push from a subdir' '
+ stg pop &&
+ [ "$(echo $(cat x.txt))" = "x0 x1" ] &&
+ [ "$(echo $(cat foo/y.txt))" = "y0 y1" ] &&
+ stg new extra -m extra &&
+ echo extra >> extra.txt &&
+ stg add extra.txt &&
+ stg refresh &&
+ cd foo &&
+ stg push &&
+ cd .. &&
+ [ "$(echo $(cat x.txt))" = "x0 x1 x2" ] &&
+ [ "$(echo $(cat foo/y.txt))" = "y0 y1 y2" ]
+'
+
+test_expect_failure 'Conflicting push from subdir' '
+ stg pop p1 p2 &&
+ [ "$(echo $(cat x.txt))" = "x0" ] &&
+ [ "$(echo $(cat foo/y.txt))" = "y0" ] &&
+ cd foo &&
+ ! stg push p2 &&
+ cd .. &&
+ [ "$(echo $(stg status --conflict))" = "foo/y.txt x.txt" ]
+'
+
+test_done
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [StGit PATCH 3/5] Make "stg push" subdirectory safe
2007-10-07 23:24 [StGit PATCH 0/5] Make push and refresh subdirectory safe Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 1/5] Infrastructure for current directory handling Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 2/5] New test: Try "stg push" in a subdirectory Karl Hasselström
@ 2007-10-07 23:24 ` Karl Hasselström
2007-10-07 23:25 ` [StGit PATCH 4/5] New test: try "stg refresh" in a subdirectory Karl Hasselström
2007-10-07 23:25 ` [StGit PATCH 5/5] Make "stg refresh" subdirectory safe Karl Hasselström
4 siblings, 0 replies; 6+ messages in thread
From: Karl Hasselström @ 2007-10-07 23:24 UTC (permalink / raw
To: Catalin Marinas; +Cc: git
Make "stg push" subdirectory safe by letting it internally cd up to
the top of the worktree. This is possibly not the best long-term fix;
one could argue that the push subroutine should instead be safe to run
from a subdirectory. However, pushing from a subdirectory currently
erases the parts of a patch that doesn't touch that subdirectory, and
that has to be fixed.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
stgit/commands/push.py | 2 +-
t/t1205-push-subdir.sh | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/stgit/commands/push.py b/stgit/commands/push.py
index b91bc5e..4d5de26 100644
--- a/stgit/commands/push.py
+++ b/stgit/commands/push.py
@@ -39,7 +39,7 @@ command run.
The command also notifies when the patch becomes empty (fully merged
upstream) or is modified (three-way merged) by the 'push' operation."""
-directory = DirectoryHasRepository()
+directory = DirectoryGotoToplevel()
options = [make_option('-a', '--all',
help = 'push all the unapplied patches',
action = 'store_true'),
diff --git a/t/t1205-push-subdir.sh b/t/t1205-push-subdir.sh
index 6502c20..f9a84f6 100755
--- a/t/t1205-push-subdir.sh
+++ b/t/t1205-push-subdir.sh
@@ -27,7 +27,7 @@ test_expect_success 'Fast-forward push from a subdir' '
[ "$(echo $(cat foo/y.txt))" = "y0 y1 y2" ]
'
-test_expect_failure 'Modifying push from a subdir' '
+test_expect_success 'Modifying push from a subdir' '
stg pop &&
[ "$(echo $(cat x.txt))" = "x0 x1" ] &&
[ "$(echo $(cat foo/y.txt))" = "y0 y1" ] &&
@@ -42,7 +42,7 @@ test_expect_failure 'Modifying push from a subdir' '
[ "$(echo $(cat foo/y.txt))" = "y0 y1 y2" ]
'
-test_expect_failure 'Conflicting push from subdir' '
+test_expect_success 'Conflicting push from subdir' '
stg pop p1 p2 &&
[ "$(echo $(cat x.txt))" = "x0" ] &&
[ "$(echo $(cat foo/y.txt))" = "y0" ] &&
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [StGit PATCH 4/5] New test: try "stg refresh" in a subdirectory
2007-10-07 23:24 [StGit PATCH 0/5] Make push and refresh subdirectory safe Karl Hasselström
` (2 preceding siblings ...)
2007-10-07 23:24 ` [StGit PATCH 3/5] Make "stg push" subdirectory safe Karl Hasselström
@ 2007-10-07 23:25 ` Karl Hasselström
2007-10-07 23:25 ` [StGit PATCH 5/5] Make "stg refresh" subdirectory safe Karl Hasselström
4 siblings, 0 replies; 6+ messages in thread
From: Karl Hasselström @ 2007-10-07 23:25 UTC (permalink / raw
To: Catalin Marinas; +Cc: git
Currently, it doesn't work. Or rather, it does work for changes that
are already in the index, which is the case for newly added files; but
it doesn't work for changes that aren't in the index.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
t/t2300-refresh-subdir.sh | 27 +++++++++++++++++++++++++++
1 files changed, 27 insertions(+), 0 deletions(-)
create mode 100755 t/t2300-refresh-subdir.sh
diff --git a/t/t2300-refresh-subdir.sh b/t/t2300-refresh-subdir.sh
new file mode 100755
index 0000000..d1c7168
--- /dev/null
+++ b/t/t2300-refresh-subdir.sh
@@ -0,0 +1,27 @@
+#!/bin/sh
+test_description='Test the refresh command from a subdirectory'
+. ./test-lib.sh
+stg init
+
+test_expect_success 'Refresh from a subdirectory' '
+ stg new foo -m foo &&
+ echo foo >> foo.txt &&
+ mkdir bar &&
+ echo bar >> bar/bar.txt &&
+ stg add foo.txt bar/bar.txt &&
+ cd bar &&
+ stg refresh &&
+ cd .. &&
+ [ "$(stg status)" = "" ]
+'
+
+test_expect_failure 'Refresh again' '
+ echo foo2 >> foo.txt &&
+ echo bar2 >> bar/bar.txt &&
+ cd bar &&
+ stg refresh &&
+ cd .. &&
+ [ "$(stg status)" = "" ]
+'
+
+test_done
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [StGit PATCH 5/5] Make "stg refresh" subdirectory safe
2007-10-07 23:24 [StGit PATCH 0/5] Make push and refresh subdirectory safe Karl Hasselström
` (3 preceding siblings ...)
2007-10-07 23:25 ` [StGit PATCH 4/5] New test: try "stg refresh" in a subdirectory Karl Hasselström
@ 2007-10-07 23:25 ` Karl Hasselström
4 siblings, 0 replies; 6+ messages in thread
From: Karl Hasselström @ 2007-10-07 23:25 UTC (permalink / raw
To: Catalin Marinas; +Cc: git
Make "stg refresh" subdirectory safe by letting it internally cd up to
the top of the worktree. This is possibly not the best long-term fix;
one could argue that the refresh subroutine should instead be safe to
run from a subdirectory. However, refreshing from a subdirectory
currently only refreshes changes that are in the index, and not
changes in the working directory, and that has to be fixed.
Signed-off-by: Karl Hasselström <kha@treskal.com>
---
stgit/commands/refresh.py | 2 +-
t/t2300-refresh-subdir.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/stgit/commands/refresh.py b/stgit/commands/refresh.py
index b283892..f032375 100644
--- a/stgit/commands/refresh.py
+++ b/stgit/commands/refresh.py
@@ -37,7 +37,7 @@ options. The '--force' option is useful when a commit object was
created with a different tool but the changes need to be included in
the current patch."""
-directory = DirectoryHasRepository()
+directory = DirectoryGotoToplevel()
options = [make_option('-f', '--force',
help = 'force the refresh even if HEAD and '\
'top differ',
diff --git a/t/t2300-refresh-subdir.sh b/t/t2300-refresh-subdir.sh
index d1c7168..bdd27c5 100755
--- a/t/t2300-refresh-subdir.sh
+++ b/t/t2300-refresh-subdir.sh
@@ -15,7 +15,7 @@ test_expect_success 'Refresh from a subdirectory' '
[ "$(stg status)" = "" ]
'
-test_expect_failure 'Refresh again' '
+test_expect_success 'Refresh again' '
echo foo2 >> foo.txt &&
echo bar2 >> bar/bar.txt &&
cd bar &&
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-10-07 23:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-07 23:24 [StGit PATCH 0/5] Make push and refresh subdirectory safe Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 1/5] Infrastructure for current directory handling Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 2/5] New test: Try "stg push" in a subdirectory Karl Hasselström
2007-10-07 23:24 ` [StGit PATCH 3/5] Make "stg push" subdirectory safe Karl Hasselström
2007-10-07 23:25 ` [StGit PATCH 4/5] New test: try "stg refresh" in a subdirectory Karl Hasselström
2007-10-07 23:25 ` [StGit PATCH 5/5] Make "stg refresh" subdirectory safe Karl Hasselström
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).