From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Bart Trojanowski <bart@jukie.net>, git@vger.kernel.org
Subject: Re: [PATCH] Add git-rev-list --invert-match
Date: Fri, 21 Sep 2007 05:19:03 -0400 [thread overview]
Message-ID: <20070921091902.GA1870@coredump.intra.peff.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0709210904210.28395@racer.site>
On Fri, Sep 21, 2007 at 10:10:12AM +0100, Johannes Schindelin wrote:
> Indeed, it has a certain elegance to it. However, I cannot specify any
> rev-list options with your method, not even "--stat" or
> "--pretty=format:%H(%s)".
Actually, you can pass --stat, but it erroneously is counted as part of
the message due to a parsing bug in the script. However you are pointing
out a larger issue, which is that the format must be parseable by the
script. As a final step, the script could turn the output into a list of
commits, and pipe them into a git command which pretty-printed in the
desired format.
But that is doubly hack-ish, and slow to boot.
> So while your script is a good interim solution, I'd like to see a
> generic grep support for this feature.
Yes, I don't seriously propose it for mainline git. However, I quite
like the interface; unfortunately, to get it to work smoothly (and
efficiently!) the perl interpreter would need to be embedded inside
git-log. And I think I know what you will say about that... :)
-Peff
prev parent reply other threads:[~2007-09-21 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 20:26 [PATCH] Add git-rev-list --invert-match Bart Trojanowski
2007-09-20 2:52 ` Bart Trojanowski
2007-09-20 4:05 ` Junio C Hamano
2007-09-20 12:18 ` Bart Trojanowski
2007-09-20 10:32 ` Johannes Schindelin
2007-09-20 12:38 ` Bart Trojanowski
2007-09-20 13:12 ` Johannes Schindelin
2007-09-20 21:49 ` Junio C Hamano
2007-09-20 21:54 ` Johannes Schindelin
2007-09-22 1:38 ` [RFC] Add git-rev-list --not-(author|committer|grep)!=pattern Bart Trojanowski
2007-09-21 4:18 ` [PATCH] Add git-rev-list --invert-match Jeff King
2007-09-21 9:10 ` Johannes Schindelin
2007-09-21 9:19 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921091902.GA1870@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=bart@jukie.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).