On Wednesday 19 September 2007 20:15:03 David Brown wrote: > git-p4 was missing the execute bit setting if the file had other attribute > bits set. > --- > contrib/fast-import/git-p4 | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 > index adaaae6..50850b8 100755 > --- a/contrib/fast-import/git-p4 > +++ b/contrib/fast-import/git-p4 > @@ -932,7 +932,10 @@ class P4Sync(Command): > data = file['data'] > > mode = "644" > - if file["type"].startswith("x"): > + if (file["type"].startswith("x") or > + file["type"].startswith("cx") or > + file["type"].startswith("kx") or > + file["type"].startswith("ux")): > mode = "755" > elif file["type"] == "symlink": > mode = "120000" I'm fine with this, so unless you find a better way: Acked-By: Simon Hausmann Simon