From: Pierre Habouzit <madcoder@debian.org>
To: Git ML <git@vger.kernel.org>
Subject: Re: xmemdup patches
Date: Mon, 17 Sep 2007 18:14:20 +0200 [thread overview]
Message-ID: <20070917161420.GC460@artemis.corp> (raw)
In-Reply-To: <20070917161113.GB460@artemis.corp>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
On lun, sep 17, 2007 at 04:11:13 +0000, Pierre Habouzit wrote:
> There were 41 of those places.
I forgot to say, I replaced _some_ xstrndup uses with a xmemdup when
it was clear to me that xmemdup was Okay. I left some alone when it
wasn't obvious in the first 10 seconds that xmemdup would work the same
way.
The real goal is code brevity and readability, xstrndup or xmemdup are
the same in that regard, and I don't think the small performance gain is
really worth the headache.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-09-17 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 16:11 xmemdup patches Pierre Habouzit
2007-09-15 21:53 ` [PATCH 1/2] Add xmemdup that duplicates a block of memory, and NUL terminates it Pierre Habouzit
2007-09-15 22:32 ` [PATCH 2/2] Use xmemdup in many places Pierre Habouzit
2007-09-19 8:08 ` Junio C Hamano
2007-09-19 8:26 ` Pierre Habouzit
2007-09-17 16:14 ` Pierre Habouzit [this message]
2007-09-17 16:39 ` xmemdup patches Johannes Schindelin
2007-09-17 17:43 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917161420.GC460@artemis.corp \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).