git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] git-commit: Add --no-status option
Date: Fri, 7 Sep 2007 00:15:57 +0200	[thread overview]
Message-ID: <20070906221557.GA20575@steel.home> (raw)
In-Reply-To: <20070905234953.GB643@nomad.office.altlinux.org>

Dmitry V. Levin, Thu, Sep 06, 2007 01:49:53 +0200:
> By default, git-commit runs git-runstatus to print changes between
> the index and the working tree.  This operation is very costly and
> is not always necessary.  New option allows user to commit without
> running git-runstatus when appropriate.

Not a very good name for the option. Noone, except for a few, knows
that git-commit runs runstatus. The name makes no sense.

"git-commit --index", perhaps (the current state of index to be
commited). Or "git-commit --prepared" (the commit is prepared and
there can be stored immediately). Even a dumb "--fast" would be
better (because it is the purpose of the patch).

Besides, now when you disabled runstatus, you better check for changes
in the index with something like "git diff --quiet --cached".

      reply	other threads:[~2007-09-06 22:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-05 23:49 [PATCH 2/2] git-commit: Add --no-status option Dmitry V. Levin
2007-09-06 22:15 ` Alex Riesen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070906221557.GA20575@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).