From: "Shawn O. Pearce" <spearce@spearce.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/3] git-gui/Makefile: Replace libdir with gitgui_libdir
Date: Wed, 5 Sep 2007 22:32:27 -0400 [thread overview]
Message-ID: <20070906023227.GH18160@spearce.org> (raw)
In-Reply-To: <20070905232153.GA331@nomad.office.altlinux.org>
"Dmitry V. Levin" <ldv@altlinux.org> wrote:
> On GNU/Linux, libdir is used to mean "/usr/lib or /usr/lib64"
> depending on architecture. Different libdir meaning breaks
> idiomatic expressions like rpm specfile "make libdir=%_libdir".
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
> git-gui/Makefile | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
Although I could apply this with `am -3` I'm NACK'ing this right
now because...
> diff --git a/git-gui/Makefile b/git-gui/Makefile
> index 1bac6fe..f143b2c 100644
> --- a/git-gui/Makefile
> +++ b/git-gui/Makefile
> @@ -76,8 +76,8 @@ SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))
> TCL_PATH_SQ = $(subst ','\'',$(TCL_PATH))
> TCLTK_PATH_SQ = $(subst ','\'',$(TCLTK_PATH))
>
> -libdir ?= $(sharedir)/git-gui/lib
> -libdir_SQ = $(subst ','\'',$(libdir))
> +gitgui_libdir ?= $(sharedir)/git-gui/lib
> +gitgui_libdir_SQ = $(subst ','\'',$(gitgui_libdir))
git-gui is its own project with its own Makefile. Junio includes
it in git.git to help widen its audience, and because it is quite
portable and easy for him to include. In the future git-gui will
become a proper subproject of git.git.
If you want to define libdir in git's toplevel Makefile *and*
that definition is being exported down into git-gui's Makefile
then I think git's toplevel Makefile should arrange for it to
not export libdir down into git-gui.
Of course one has to wonder if that is even possible in GNU make.
I'm not a GNU make expert so I don't really know.
--
Shawn.
next prev parent reply other threads:[~2007-09-06 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 23:21 [PATCH 1/3] git-gui/Makefile: Replace libdir with gitgui_libdir Dmitry V. Levin
2007-09-06 2:32 ` Shawn O. Pearce [this message]
2007-09-06 10:00 ` Dmitry V. Levin
2007-09-07 5:01 ` Shawn O. Pearce
2007-09-07 12:44 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906023227.GH18160@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).