From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Mike Hommey <mh@glandium.org>, git@vger.kernel.org
Subject: Re: Significant performance waste in git-svn and friends
Date: Wed, 5 Sep 2007 22:16:59 -0400 [thread overview]
Message-ID: <20070906021659.GE18160@spearce.org> (raw)
In-Reply-To: <7vd4wwj16d.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > The same things obviously apply to git-cvsimport and other scripts
> > calling git-hash-object a lot.
>
> I *obviously* hate this patch, as it makes this Porcelain
> command to be aware of the internal representation too much.
Me too. I think its bad enough that fast-import knows the
internal representation of a packfile. And its plumbing!
> I wonder if letting fast-import handle the object creation is an
> option, though.
I agree. This is *exactly* what fast-import was built for. It
really would be the better tool to use here. Much better than
reinventing the wheel. Its already been invented twice for you
in Git (normal object creation path and fast-import path). No
need to do it a third time.
--
Shawn.
next prev parent reply other threads:[~2007-09-06 2:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 18:47 Significant performance waste in git-svn and friends Mike Hommey
2007-09-05 20:40 ` Junio C Hamano
2007-09-05 21:19 ` David Kastrup
2007-09-06 1:07 ` Patrick Doyle
2007-09-06 2:19 ` Shawn O. Pearce
2007-09-06 2:16 ` Shawn O. Pearce [this message]
2007-09-06 5:52 ` Mike Hommey
2007-09-06 7:04 ` Eric Wong
2007-09-07 4:55 ` Shawn O. Pearce
2007-09-07 6:28 ` Steven Grimm
2007-09-07 5:41 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906021659.GE18160@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).