git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list
@ 2007-09-05 23:22 Dmitry V. Levin
  2007-09-06  0:16 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry V. Levin @ 2007-09-05 23:22 UTC (permalink / raw)
  To: Git Mailing List; +Cc: Junio C Hamano

Some external projects (e.g. parsecvs) need cache-tree.h file.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index d50e30b..2b04829 100644
--- a/Makefile
+++ b/Makefile
@@ -283,7 +283,7 @@ LIB_FILE=libgit.a
 XDIFF_LIB=xdiff/lib.a
 
 LIB_H = \
-	archive.h blob.h cache.h commit.h csum-file.h delta.h grep.h \
+	archive.h blob.h cache.h cache-tree.h commit.h csum-file.h delta.h grep.h \
 	diff.h object.h pack.h pkt-line.h quote.h refs.h list-objects.h sideband.h \
 	run-command.h strbuf.h tag.h tree.h git-compat-util.h revision.h \
 	tree-walk.h log-tree.h dir.h path-list.h unpack-trees.h builtin.h \
-- 
ldv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list
  2007-09-05 23:22 [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list Dmitry V. Levin
@ 2007-09-06  0:16 ` Junio C Hamano
  2007-09-06  0:37   ` Dmitry V. Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2007-09-06  0:16 UTC (permalink / raw)
  To: Dmitry V. Levin; +Cc: Git Mailing List

"Dmitry V. Levin" <ldv@altlinux.org> writes:

> Some external projects (e.g. parsecvs) need cache-tree.h file.

Your patch shows that our Makefile has been lacking a necessary
dependency for a long time.  LIB_H is not "public headers list",
but more like "the headers everybody depends on", and the header
file should have been on that list.  Thanks.

I am however not convinced it is a good idea to treat libgit.a
as if it is a library.  It is not a library in the usual sense
of the word.  Originally we did libgit.a primarily so that we do
not have to list all the *.o dependencies in the Makefile out of
laziness ;-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list
  2007-09-06  0:16 ` Junio C Hamano
@ 2007-09-06  0:37   ` Dmitry V. Levin
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry V. Levin @ 2007-09-06  0:37 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Git Mailing List

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

On Wed, Sep 05, 2007 at 05:16:47PM -0700, Junio C Hamano wrote:
[...]
> I am however not convinced it is a good idea to treat libgit.a
> as if it is a library.
> It is not a library in the usual sense of the word.

I'd certainly prefer libgit.so with stable interface instead, but
parsecvs needs -lgit now, it cannot wait for "good library".


-- 
ldv

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-09-06  0:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-05 23:22 [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list Dmitry V. Levin
2007-09-06  0:16 ` Junio C Hamano
2007-09-06  0:37   ` Dmitry V. Levin

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).