Re: [StGIT PATCH 4/4] Add optional logging of subprocess execution

["Karl Hasselström" <kha@treskal.com>]

On 2007-08-29 11:50:11 +0100, Catalin Marinas wrote:

> On 26/08/2007, Karl Hasselström <kha@treskal.com> wrote:
>
> > Now that the subprocess calling has been refactored and is in a
> > nice shape, it's quite simple to add some logging facilities. This
> > patch adds two separate log modes, switched by the
> > STG_SUBPROCESS_LOG environment variable:
>
> Any objection to calling this variable STGIT_SUBPROCESS_LOG? We
> already have STGIT_DEBUG_LEVEL (used in stgit.main). I can do it in
> my tree before pushing as I already merged your branches.

No, no objection at all. I was simply too lazy to actually check what
the existing naming convention was, and misremembered.

> BTW, thanks for refactoring the subprocess calling.

It needed doing, and was actually fun.

Any chance we can drop Python 2.3 support any time soon, by the way?
I've confined all the ickyness to one place, but it would still be
good to get rid of it (not to mention being able to use sets and
generator expressions).

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle