git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org
Subject: Re: [RFC] remarks about custom diff driver
Date: Mon, 27 Aug 2007 06:45:29 -0400	[thread overview]
Message-ID: <20070827104529.GA25685@coredump.intra.peff.net> (raw)
In-Reply-To: <vpq8x7x5knh.fsf@bauges.imag.fr>

On Mon, Aug 27, 2007 at 12:36:34PM +0200, Matthieu Moy wrote:

> Indeed, what I would have needed is a custum text converter. In my
> case, I would have said something like
> 
> [...]
>
> Any opinion? Do you think that's overkill? Anyone else have a
> particuliar experience with custom diff engine?

Interestingly enough, I tried using a custom diff for the first time
earlier today and came to the exact same conclusion (I was diff'ing
photos that were tagged with exif keywords). I suspect a large number of
diff engines will simply want to convert content into a canonical text
format.

I wonder if you could simply use a "diff-filter" attribute that would
clean and smudge in the same way as "filter", except it would only do so
when creating or applying diffs. In most cases, you wouldn't have a
"clean" component (since the conversion to text is lossy).

-Peff

  reply	other threads:[~2007-08-27 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-27 10:36 [RFC] remarks about custom diff driver Matthieu Moy
2007-08-27 10:45 ` Jeff King [this message]
2007-08-27 23:29 ` [RFC][PATCH] " Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070827104529.GA25685@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).