From: Petr Baudis <pasky@suse.cz>
To: Jakub Narebski <jnareb@gmail.com>
Cc: GIT list <git@vger.kernel.org>, Yann Dirson <ydirson@altern.org>
Subject: Re: [BUG] gitweb on repo.or.cz shows buggy commitdiff
Date: Mon, 27 Aug 2007 02:48:38 +0200 [thread overview]
Message-ID: <20070827004838.GO1219@pasky.or.cz> (raw)
In-Reply-To: <200708270230.04537.jnareb@gmail.com>
On Mon, Aug 27, 2007 at 02:30:04AM CEST, Jakub Narebski wrote:
> 2. Alternate solution is to note that we have split patch only in the case
> of 'T' (type change) status, and for typechange we always split patch in
> two, so there are two patches corresponding to single raw diff-tree line.
>
> So it would be enough to introduce $continued_patch variable, unset it
> after writing that patch is continued if it is true, set it to true if
> there was typechange, i.e. if status (one of status) is 'T'.
>
> And we can get rid of buffering extended diff header and parsing it,
> I think. This would simplify git_patchset_body, making it easier to
> understand and maintain.
>
> But this depends on my understanding on "git diff-tree --patch-with-raw"
> output, and that it would not change in the future WRT split patches.
I'd prefer this solution, though I think split patch could also happen
if you use -B (which I think is very good idea to use and it's a pity
that it isn't default - or is it?).
--
Petr "Pasky" Baudis
Early to rise and early to bed makes a male healthy and wealthy and dead.
-- James Thurber
next prev parent reply other threads:[~2007-08-27 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 9:46 [BUG] gitweb on repo.or.cz shows buggy commitdiff Yann Dirson
2007-08-25 20:25 ` Petr Baudis
2007-08-27 0:30 ` Jakub Narebski
2007-08-27 0:48 ` Petr Baudis [this message]
2007-08-27 1:12 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070827004838.GO1219@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).