From: "Shawn O. Pearce" <spearce@spearce.org>
To: Lars Noschinski <lars@public.noschinski.de>
Cc: git@vger.kernel.org
Subject: Re: git-gui ignores core.excludesFile
Date: Sun, 29 Jul 2007 03:22:47 -0400 [thread overview]
Message-ID: <20070729072247.GM20052@spearce.org> (raw)
In-Reply-To: <20070723150700.GA17167@lars.home.noschinski.de>
Lars Noschinski <lars@public.noschinski.de> wrote:
> It seems git-gui (0.7.5 from git 1.5.2.4 tarball) ignores the global
> ignore file configured with the core.excludesfile option. My
> ~/.gitconfig contains
>
> [core]
> excludesFile = /home/noschinski/.gitignore
>
> which is honoured by git-status but not by git-gui.
Whoops. Thanks. git-gui 0.8.0 will include the following patch:
-->8--
From 94a4dd9bfda79a226f8dd57fd20c39c6603ec194 Mon Sep 17 00:00:00 2001
From: Shawn O. Pearce <spearce@spearce.org>
Date: Sun, 29 Jul 2007 03:22:27 -0400
Subject: [PATCH] git-gui: Honor core.excludesfile when listing extra files
Recent git versions have a git-status that honors the core.excludesfile
configuration option when it reports on untracked files. Unfortunately
I missed the introduction of this configuration option in the core
porcelain implementation, so it was not reflected here in git-gui.
Found and reported by Lars Noschinski <lars@public.noschinski.de>.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
git-gui.sh | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index d7fad46..4e3b58c 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -872,6 +872,10 @@ proc rescan_stage2 {fd after} {
if {[file readable $info_exclude]} {
lappend ls_others "--exclude-from=$info_exclude"
}
+ set user_exclude [get_config core.excludesfile]
+ if {$user_exclude ne {} && [file readable $user_exclude]} {
+ lappend ls_others "--exclude-from=$user_exclude"
+ }
set buf_rdi {}
set buf_rdf {}
--
1.5.3.rc3.843.g25b4
--
Shawn.
prev parent reply other threads:[~2007-07-29 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 15:07 git-gui ignores core.excludesFile Lars Noschinski
2007-07-29 7:22 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070729072247.GM20052@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=lars@public.noschinski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).