From: Sven Verdoolaege <skimo@kotnet.org>
To: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: extend sanitize_address_rfc822 to do rfc2047 quoting
Date: Wed, 11 Jul 2007 10:42:32 +0200 [thread overview]
Message-ID: <20070711084232.GE1528MdfPADPa@greensroom.kotnet.org> (raw)
In-Reply-To: <11840869641759-git-send-email-ukleinek@informatik.uni-freiburg.de>
On Tue, Jul 10, 2007 at 07:02:43PM +0200, Uwe Kleine-König wrote:
> my ($recipient) = @_;
> - my ($recipient_name) = ($recipient =~ /^(.*?)\s+</);
> + my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)(\s+<.*)/);
> +
> + if ($recipient_name && $recipient_name =~ /[^-a-zA-Z0-9!*+\/ ]/ && $recipient_name !~ /=\?utf-8\?q?.*\?=/) {
Why the extra test for truthness of $recipient_name ?
> if ($recipient_name && $recipient_name =~ /\./ && $recipient_name !~ /^".*"$/) {
> - my ($name, $addr) = ($recipient =~ /^(.*?)(\s+<.*)/);
> - $recipient = "\"$name\"$addr";
> + $recipient_name = "\"$recipient_name\"";
> + }
> +
> + if ($recipient_name) {
> + return "$recipient_name$recipient_addr";
> + } else {
> + return "$recipient";
> }
> - return $recipient;
Why did you introduce interpolation just to get $recipient again?
Then again, why do you need a test at all here?
return $recipient_name . $recipient_addr;
should work, no?
skimo
next prev parent reply other threads:[~2007-07-11 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 17:02 [PATCH] send-email: extend sanitize_address_rfc822 to do rfc2047 quoting Uwe Kleine-König
2007-07-10 17:02 ` [PATCH] [RFC] send-email: honor --suppress-from --signed-off-cc Uwe Kleine-König
2007-07-11 7:55 ` Uwe Kleine-König
2007-07-11 8:42 ` Sven Verdoolaege [this message]
2007-07-11 11:49 ` [PATCH] send-email: extend sanitize_address_rfc822 to do rfc2047 quoting Uwe Kleine-König
2007-07-11 12:08 ` Sven Verdoolaege
[not found] ` <81b0412b0707110538s7eda05e8g6973e20fc4d91931@mail.gmail.com>
2007-07-11 12:49 ` Sven Verdoolaege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711084232.GE1528MdfPADPa@greensroom.kotnet.org \
--to=skimo@kotnet.org \
--cc=git@vger.kernel.org \
--cc=skimo@liacs.nl \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).