From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] hooks/commit-msg: add example to add Signed-off-by line to message
Date: Fri, 22 Dec 2006 09:28:07 +0000 [thread overview]
Message-ID: <200612220928.08921.andyparkins@gmail.com> (raw)
In-Reply-To: <7v64c47abv.fsf@assigned-by-dhcp.cox.net>
On Friday 2006 December 22 05:45, Junio C Hamano wrote:
> I suspect this sed script is quite wrong. Did you test it?
I plead not guilty; cut and pasted from Johannes. In it's defence; I've been
using it since he gave it to me without trouble. My patch is wrapping it a
little differently, but the sed is certainly the same.
Amazingly it does work though...
> * quoting with dq means you are losing one level of backslash
> to the shell and sed is not seeing them.
Unusual. It doesn't seem to apply to non-recognised escapes:
$ echo "\1\(\)\+$/"
\1\(\)\+$/
> * one-or-more regexp '+' is typically not found in sed.
Seems to be in mine (GNU sed version 4.1.5).
$ echo "xxxxxx" | sed -n 's/\(x\+\)$/MATCH/p'
MATCH
> off that new change as well, I think. So checking the last
> instance of the existing signed-off-by line, ignoring earlier
> ones, may be more preferrable.
Accepted.
Notwithstanding the fact that it seems to be working for me; I'll fix the
problems you highlight and re-patch.
Andy
--
Dr Andy Parkins, M Eng (hons), MIEE
andyparkins@gmail.com
prev parent reply other threads:[~2006-12-22 9:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 11:20 [PATCH] hooks/pre-commit: add example to add Signed-off-by line to message Johannes Schindelin
2006-12-20 15:54 ` Andy Parkins
2006-12-20 16:04 ` Andy Parkins
2006-12-20 16:18 ` Johannes Schindelin
2006-12-20 17:29 ` Junio C Hamano
2006-12-20 17:37 ` Johannes Schindelin
2006-12-20 17:44 ` Junio C Hamano
2006-12-21 8:26 ` Johannes Schindelin
2006-12-21 9:24 ` [PATCH] hooks/commit-msg: " Andy Parkins
2006-12-22 5:45 ` Junio C Hamano
2006-12-22 9:28 ` Andy Parkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612220928.08921.andyparkins@gmail.com \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).