From: Rocco Rutte <pdmef@gmx.net>
To: git@vger.kernel.org
Subject: Re: [PATCH] Don't define _XOPEN_SOURCE on MacOSX and FreeBSD as it is too restricting
Date: Fri, 22 Dec 2006 06:53:27 +0000 [thread overview]
Message-ID: <20061222065327.GA3773@peter.daprodeges.fqdn.th-h.de> (raw)
In-Reply-To: <7v64c492fv.fsf@assigned-by-dhcp.cox.net>
Hi,
* Junio C Hamano [06-12-21 16:52:52 -0800] wrote:
>Marco Roeland <marco.roeland@xs4all.nl> writes:
>> We want our symbols "avilable" so lets not use _XOPEN_SOURCE on Darwin!
>Personally, I think hiding interfaces such as strXXX and memXXX
>based on _XOPEN_SOURCE level is already a bug in the system
>header implementation. The symbols that begin with str are
>already reserved by the standard and I do not see any point
>in the system headers to try avoiding namespace contamination.
Well, it depends, I'd say. Different strXXX functions may be introduced
by different versions of standards and with _POSIX_C_SOURCE one can, for
example, define to be compile for a specific standard version only.
>Two and half questions.
> #1 __APPLE__ vs __APPLE_CC__ is not something I can decide (I
> do not run a Mac). If MaxOS is derived from FreeBSD, does
> it by chance define __FreeBSD as well?
> #2 Terje's patch excludes _XOPEN_SOURCE_EXTENDED as well on a
> Mac, but yours doesn't. Is there a reason that you would
> want '#define _XOPEN_SOURCE_EXTENDED 1'? Do both FreeBSD
> and Mac behave well with it defined?
First of all, the combined patch posted is wrong since __FreeBSD doesn't
work on FreeBSD, but __FreeBSD__ does.
Second, a grep over the FreeBSD headers in /usr/include shows that
_XOPEN_SOURCE_EXTENDED only affects 2 curses header files, so it's safe
to exclude it, i.e. define it for FreeBSD.
bye, Rocco
--
:wq!
next prev parent reply other threads:[~2006-12-22 6:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 20:48 What's in git.git (stable), and Announcing GIT 1.4.4.3 Junio C Hamano
2006-12-20 22:04 ` Randal L. Schwartz
2006-12-20 22:14 ` Linus Torvalds
2006-12-20 22:20 ` [BUG] daemon.c blows up on OSX (was Re: What's in git.git (stable), and Announcing GIT 1.4.4.3) Randal L. Schwartz
2006-12-20 22:25 ` [BUG] daemon.c blows up on OSX Junio C Hamano
2006-12-20 22:35 ` Randal L. Schwartz
2006-12-20 22:44 ` Junio C Hamano
2006-12-20 22:46 ` Randal L. Schwartz
2006-12-20 23:03 ` Junio C Hamano
2006-12-20 23:25 ` Randal L. Schwartz
2006-12-20 23:34 ` Randal L. Schwartz
2006-12-21 2:04 ` Stefan Pfetzing
2006-12-20 23:07 ` Linus Torvalds
2006-12-20 23:17 ` Randal L. Schwartz
2006-12-20 23:30 ` Junio C Hamano
2006-12-20 23:41 ` Linus Torvalds
2006-12-21 0:36 ` Terje Sten Bjerkseth
2006-12-21 0:44 ` Junio C Hamano
2006-12-21 0:54 ` Terje Sten Bjerkseth
2006-12-21 1:00 ` Junio C Hamano
2006-12-21 1:20 ` Randal L. Schwartz
2006-12-21 1:29 ` Junio C Hamano
2006-12-21 1:35 ` Terje Sten Bjerkseth
2006-12-21 10:39 ` [PATCH] Do not define _XOPEN_SOURCE on MacOSX as it is too restricting there Marco Roeland
2006-12-21 11:28 ` [PATCH] Don't define _XOPEN_SOURCE on MacOSX and FreeBSD as it is too restricting Marco Roeland
2006-12-22 0:52 ` Junio C Hamano
2006-12-22 1:04 ` Shawn Pearce
2006-12-22 6:53 ` Rocco Rutte [this message]
2006-12-22 7:51 ` Marco Roeland
2006-12-22 8:37 ` Junio C Hamano
2006-12-22 11:47 ` Marco Roeland
2006-12-22 12:55 ` Rocco Rutte
2006-12-22 13:14 ` Marco Roeland
2007-01-03 15:25 ` [BUG] daemon.c blows up on OSX Andreas Ericsson
2006-12-21 0:44 ` Linus Torvalds
2006-12-21 1:07 ` Randal L. Schwartz
2006-12-21 1:13 ` Junio C Hamano
2006-12-21 1:08 ` Randal L. Schwartz
[not found] ` <24BF45E9-DD98-4609-9D65-B01EAA30CCA8@silverinsanity.com>
2006-12-21 1:35 ` Randal L. Schwartz
2006-12-21 1:48 ` Junio C Hamano
2006-12-21 1:50 ` Randal L. Schwartz
2006-12-21 1:57 ` Junio C Hamano
2006-12-20 23:58 ` What's in git.git (stable), and Announcing GIT 1.4.4.3 Randal L. Schwartz
2006-12-20 22:17 ` Junio C Hamano
2006-12-21 8:43 ` Johannes Schindelin
2006-12-21 8:52 ` Junio C Hamano
2006-12-20 22:19 ` Nicolas Pitre
2006-12-21 11:38 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061222065327.GA3773@peter.daprodeges.fqdn.th-h.de \
--to=pdmef@gmx.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).