From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] Don't crash during repack of a reflog with pruned commits.
Date: Thu, 21 Dec 2006 19:56:06 -0500 [thread overview]
Message-ID: <20061222005606.GA14773@spearce.org> (raw)
In-Reply-To: <20061222004906.GC14789@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote:
> If the user has been using reflog for a long time (e.g. since its
> introduction) then it is very likely that an existing branch's
> reflog may still mention commits which have long since been pruned
> out of the repository.
>
> Rather than aborting with a very useless error message during
> git-repack, pack as many valid commits as we can get from the
> reflog and let the user know that the branch's reflog contains
> already pruned commits. A future 'git reflog expire' (or whatever
> it finally winds up being called) can then be performed to expunge
> those reflog entries.
If its not obvious from the patch, this doesn't entirely fix the
problem.
Just because the commit has not been pruned does not mean that a blob
or tree referenced by that commit has not been pruned. Right now
I am missing 1 blob and cannot repack because of it.
At least with this series of 3 patches the error message resulting
from this one missing blob is clearer.
--
Shawn.
next prev parent reply other threads:[~2006-12-22 0:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <be6b1443171482e1930bd7744a0218db0c03d611.1166748450.git.spearce@spearce.org>
2006-12-22 0:48 ` [PATCH 2/3] Introduce a global level warn() function Shawn O. Pearce
2006-12-22 0:49 ` [PATCH 3/3] Don't crash during repack of a reflog with pruned commits Shawn O. Pearce
2006-12-22 0:52 ` Junio C Hamano
2006-12-22 1:00 ` Shawn Pearce
2006-12-22 1:18 ` Jakub Narebski
2006-12-22 1:23 ` Shawn Pearce
2006-12-22 0:56 ` Shawn Pearce [this message]
2006-12-22 8:16 ` Junio C Hamano
2006-12-22 8:22 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061222005606.GA14773@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).