From: Petr Baudis <pasky@suse.cz>
To: Kir Kolyshkin <kir@openvz.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: make HTML links out of http/https URLs in changelogs
Date: Wed, 22 Nov 2006 21:56:52 +0100 [thread overview]
Message-ID: <20061122205652.GL7201@pasky.or.cz> (raw)
In-Reply-To: <45641195.2000804@openvz.org>
On Wed, Nov 22, 2006 at 10:00:05AM CET, Kir Kolyshkin wrote:
> Petr Baudis wrote:
> >On Tue, Nov 21, 2006 at 11:02:36PM CET, Kir Kolyshkin wrote:
> >
> >>Slightly tested on http://git.openvz.org/. Applicable to git-1.4.4.
> >>
> >
> >...but in git's gitweb view it will make this <a
> >href="http://git.openvz.org/.">http://git.openvz.org/.</a>. :-)
> Not a problem actually since "." means "current directory", so it will
> work fine (and I have checked that) :)
> Sure there is a room for improvement for this regex -- and I am
> collecting those.
But "http://git.openvz.org/index.html." might not work so fine, nor
"http://git.openvz.org/,"...
Bad URLs matchers which don't snip unlikely (!= invalid!) characters
from the end of the URL are my pet peeve. ;-)
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
The meaning of Stonehenge in Traflamadorian, when viewed from above, is:
"Replacement part being rushed with all possible speed."
prev parent reply other threads:[~2006-11-22 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 22:02 [PATCH] gitweb: make HTML links out of http/https URLs in changelogs Kir Kolyshkin
2006-11-21 22:28 ` Jakub Narebski
2006-11-21 23:55 ` Randal L. Schwartz
2006-11-22 0:06 ` Petr Baudis
2006-11-22 9:00 ` Kir Kolyshkin
2006-11-22 20:56 ` Petr Baudis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061122205652.GL7201@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=kir@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).