From: Shawn Pearce <spearce@spearce.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Eran Tromer <git2eran@tromer.org>, Nicolas Pitre <nico@cam.org>,
Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org
Subject: Re: fetching packs and storing them as packs
Date: Fri, 27 Oct 2006 03:52:29 -0400 [thread overview]
Message-ID: <20061027075229.GD29057@spearce.org> (raw)
In-Reply-To: <81b0412b0610270042w29279b90t7c94d8590d701519@mail.gmail.com>
Alex Riesen <raa.lkml@gmail.com> wrote:
> >So the receive-pack process becomes:
> >
> > a. Create temporary pack file in $GIT_DIR/objects/pack_XXXXX.
> >b. Create temporary index file in $GIT_DIR/objects/index_XXXXX.
>
> Why not $GIT_DIR/objects/tmp/pack... and ignore it everywhere?
Because there is a race condition.
The contents of the new pack must be accessable as a normal pack
before we update and unlock the refs that are being changed. This
means it must be a normal pack in $GIT_DIR/objects/pack.
Currently all packs under $GIT_DIR/objects/pack are deleted during
`repack -a -d`. Those packs may have been added to that directory
after the repack started resulting in them getting deleted when
the repack completes, but with none of their contained objects in
the newly created pack. Thus the repository is suddenly missing
everything that was just pushed (or fetched).
--
next prev parent reply other threads:[~2006-10-27 7:53 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 3:44 fetching packs and storing them as packs Nicolas Pitre
2006-10-26 14:45 ` Eran Tromer
[not found] ` <Pine.LNX.4.64.0610261105200.12418@xanadu.home>
2006-10-26 22:09 ` Eran Tromer
2006-10-27 0:50 ` Nicolas Pitre
2006-10-27 1:42 ` Shawn Pearce
2006-10-27 2:38 ` Sean
2006-10-27 6:57 ` Junio C Hamano
2006-10-27 17:23 ` Nicolas Pitre
2006-10-27 2:41 ` Nicolas Pitre
2006-10-27 2:42 ` Eran Tromer
2006-10-27 3:00 ` Shawn Pearce
2006-10-27 3:13 ` Sean
2006-10-27 3:20 ` Jakub Narebski
2006-10-27 3:27 ` Sean
2006-10-27 4:03 ` Eran Tromer
2006-10-27 4:42 ` Shawn Pearce
2006-10-27 7:42 ` Alex Riesen
2006-10-27 7:52 ` Shawn Pearce [this message]
2006-10-27 8:08 ` Alex Riesen
2006-10-27 8:13 ` Shawn Pearce
2006-10-27 14:27 ` Nicolas Pitre
2006-10-27 14:38 ` Petr Baudis
2006-10-27 14:48 ` J. Bruce Fields
2006-10-27 15:03 ` Petr Baudis
2006-10-27 16:04 ` J. Bruce Fields
2006-10-27 16:05 ` J. Bruce Fields
2006-10-27 18:56 ` Junio C Hamano
2006-10-27 20:22 ` Linus Torvalds
2006-10-27 21:53 ` Junio C Hamano
2006-10-28 3:42 ` Shawn Pearce
2006-10-28 4:09 ` Junio C Hamano
2006-10-28 4:18 ` Linus Torvalds
2006-10-28 5:42 ` Junio C Hamano
2006-10-28 7:21 ` Shawn Pearce
2006-10-28 8:40 ` Shawn Pearce
2006-10-28 19:15 ` Junio C Hamano
2006-10-29 3:50 ` Shawn Pearce
2006-10-29 4:29 ` Junio C Hamano
2006-10-29 4:38 ` Shawn Pearce
2006-10-29 5:16 ` Junio C Hamano
2006-10-29 5:21 ` Shawn Pearce
2006-10-28 17:59 ` Linus Torvalds
2006-10-28 18:34 ` Junio C Hamano
2006-10-28 22:31 ` Eran Tromer
2006-10-29 3:38 ` Shawn Pearce
2006-10-29 3:48 ` Jakub Narebski
2006-10-29 3:52 ` Shawn Pearce
2006-10-29 7:47 ` [PATCH] send-pack --keep: do not explode into loose objects on the receiving end Junio C Hamano
2006-10-29 7:56 ` Shawn Pearce
2006-10-29 8:05 ` Junio C Hamano
2006-10-30 1:44 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061027075229.GD29057@spearce.org \
--to=spearce@spearce.org \
--cc=git2eran@tromer.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).