* [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2
@ 2006-10-11 2:09 Luben Tuikov
2006-10-11 4:45 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Luben Tuikov @ 2006-10-11 2:09 UTC (permalink / raw
To: git
Commit eeef88cd2 introduced $group_size which
inverted the meaning of $current_color.
Normally we start with white (same as background) color
for the zebra coloring, and flip to dark shade only when
another commit changed some lines of the file. (Thus
if there are no changes, the file appears black on white.)
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 173f521..77063f0 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2583,7 +2583,7 @@ sub git_blame2 {
git_print_page_path($file_name, $ftype, $hash_base);
my @rev_color = (qw(light2 dark2));
my $num_colors = scalar(@rev_color);
- my $current_color = 0;
+ my $current_color = 1;
my $last_rev;
print <<HTML;
<div class="page_body">
--
1.4.3.rc2.gd2a59
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2
2006-10-11 2:09 [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2 Luben Tuikov
@ 2006-10-11 4:45 ` Junio C Hamano
2006-10-11 7:21 ` Luben Tuikov
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-10-11 4:45 UTC (permalink / raw
To: Luben Tuikov; +Cc: git
Luben Tuikov <ltuikov@yahoo.com> writes:
> Commit eeef88cd2 introduced $group_size which
> inverted the meaning of $current_color.
>
> Normally we start with white (same as background) color
> for the zebra coloring, and flip to dark shade only when
> another commit changed some lines of the file. (Thus
> if there are no changes, the file appears black on white.)
I do not have much preference either way, but it was done more
or less deliberately to match what you did with 6dd36ac.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2
2006-10-11 4:45 ` Junio C Hamano
@ 2006-10-11 7:21 ` Luben Tuikov
0 siblings, 0 replies; 3+ messages in thread
From: Luben Tuikov @ 2006-10-11 7:21 UTC (permalink / raw
To: Junio C Hamano; +Cc: git
--- Junio C Hamano <junkio@cox.net> wrote:
> I do not have much preference either way, but it was done more
> or less deliberately to match what you did with 6dd36ac.
Sorry, I didn't mean to introduce the apparent inconsisteny.
The 6dd36ac touches alternate "active" shading, and blame
only shows the contents, albeit with the commit-8 and block
coloring.
Luben
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-11 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-11 2:09 [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2 Luben Tuikov
2006-10-11 4:45 ` Junio C Hamano
2006-10-11 7:21 ` Luben Tuikov
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).