git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Wong <normalperson@yhbt.net>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 4/4] t6000lib: workaround a possible dash bug
Date: Fri, 26 May 2006 22:33:42 +1000	[thread overview]
Message-ID: <20060526123342.GD5372@gondor.apana.org.au> (raw)
In-Reply-To: <11486091792604-git-send-email-normalperson@yhbt.net>

On Thu, May 25, 2006 at 07:06:18PM -0700, Eric Wong wrote:
>
>  t/t6000lib.sh |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> cba907ce0b1c0927fb15cbb5dd91a4129ff9a950
> diff --git a/t/t6000lib.sh b/t/t6000lib.sh
> index c6752af..d402621 100755
> --- a/t/t6000lib.sh
> +++ b/t/t6000lib.sh
> @@ -69,7 +69,9 @@ on_committer_date()
>  {
>      _date=$1
>      shift 1
> -    GIT_COMMITTER_DATE=$_date "$@"
> +    export GIT_COMMITTER_DATE="$_date"
> +    "$@"
> +    unset GIT_COMMITTER_DATE

The original code looks correct to me.  So I think this too should
be fixed in dash instead.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2006-05-26 12:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-26  2:06 [PATCH 0/4] fix tests so they run without needing bash Eric Wong
2006-05-26  2:06 ` [PATCH 1/4] t3300-funny-names: shell portability fixes Eric Wong
2006-05-26  2:06   ` [PATCH 2/4] tests: Remove heredoc usage inside quotes Eric Wong
2006-05-26  2:06     ` [PATCH 3/4] t5500-fetch-pack: remove local (bashism) usage Eric Wong
2006-05-26  2:06       ` [PATCH 4/4] t6000lib: workaround a possible dash bug Eric Wong
2006-05-26 12:33         ` Herbert Xu [this message]
2007-09-21 13:28         ` Herbert Xu
2007-09-21 20:45           ` Eric Wong
2007-09-26  8:41             ` Herbert Xu
2006-05-26 12:23       ` [PATCH 3/4] t5500-fetch-pack: remove local (bashism) usage Herbert Xu
2006-05-29  5:28         ` Eric Wong
2006-05-29  5:36           ` Junio C Hamano
2006-05-29  7:31           ` Herbert Xu
2006-05-26 12:22     ` [PATCH 2/4] tests: Remove heredoc usage inside quotes Herbert Xu
2006-05-29  5:30       ` Eric Wong
2006-05-26  3:01 ` [PATCH 0/4] fix tests so they run without needing bash Junio C Hamano
2006-05-29  5:39   ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060526123342.GD5372@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).