git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] Set the executable bit on gitMergeCommon.py.
@ 2006-05-23  8:12 Peter Eriksen
  2006-05-23  8:34 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Eriksen @ 2006-05-23  8:12 UTC (permalink / raw
  To: git

From: Peter Eriksen <s022018@student.dtu.dk>
Date: Mon, 22 May 2006 15:35:42 +0200

Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>


---

6465b4c8cc760102ed5771ccded2c02904539475
 0 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 gitMergeCommon.py

6465b4c8cc760102ed5771ccded2c02904539475
diff --git a/gitMergeCommon.py b/gitMergeCommon.py
old mode 100644
new mode 100755
-- 
1.3.3.g288c

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Set the executable bit on gitMergeCommon.py.
  2006-05-23  8:12 [PATCH] Set the executable bit on gitMergeCommon.py Peter Eriksen
@ 2006-05-23  8:34 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2006-05-23  8:34 UTC (permalink / raw
  To: Peter Eriksen; +Cc: git

"Peter Eriksen" <s022018@student.dtu.dk> writes:

> From: Peter Eriksen <s022018@student.dtu.dk>
> Date: Mon, 22 May 2006 15:35:42 +0200
>
> Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>

It makes some sense to make git-merge-recursive.py executable,
just in case somebody wants to run it without preprocessing.

However, gitMergeCommon.py is a module without the main program.
It does not even have the usual "primarily meant to be a library
but you could run it standalone" idiom at the end:

	if __name__ == '__main__': test()

So I am not sure if this patch makes sense -- does it misbehave
on your system when installed without +x bit?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-05-23  8:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-23  8:12 [PATCH] Set the executable bit on gitMergeCommon.py Peter Eriksen
2006-05-23  8:34 ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).