From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, junkio@cox.net, git@vger.kernel.org
Subject: Re: the war on trailing whitespace
Date: Sun, 26 Feb 2006 15:26:17 -0500 [thread overview]
Message-ID: <20060226202617.GH7851@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0602261213340.22647@g5.osdl.org>
On Sun, Feb 26, 2006 at 12:16:25PM -0800, Linus Torvalds wrote:
> Few enough people run "git-apply" on its own. Most people (certainly me)
> end up using it through some email-applicator script or other. So the plan
> was that the --whitespace=warn/error flag would go there, and that
> git-apply by default would work more like "patch".
>
> But hey, I have no strong preferences, and it's easy enough to make the
> default be warn (and add a "--whitespace=ok" flag to turn it off).
>
> Personally, I don't mind whitespace that much. In particular, I _suspect_
> I often have empty lines like
>
> int i;
>
> i = 10;
>
> where the "empty" line actually has the same indentation as the lines
> around it. Is that wrong? Perhaps.
I think I have the same anal-retentive problem Andrew has, because I have ..
highlight RedundantSpaces term=standout ctermbg=red guibg=red
match RedundantSpaces /\s\+$\| \+\ze\t/
in my .vimrc, which highlights this (and other trailing whitespace) as
a big red blob. I do this in part for the same reason Andrew does,
so that when someone sends me a diff with a zillion spaces at the EOL,
it screams at me, I spot them, and chop them out.
Dave
next prev parent reply other threads:[~2006-02-26 20:26 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-26 1:40 the war on trailing whitespace Andrew Morton
2006-02-26 3:38 ` Junio C Hamano
2006-02-26 5:07 ` Andrew Morton
2006-02-26 17:29 ` Linus Torvalds
2006-02-26 18:36 ` Andrew Morton
2006-02-26 20:16 ` Linus Torvalds
2006-02-26 20:26 ` Dave Jones [this message]
2006-02-26 20:31 ` Dave Jones
2006-02-27 2:50 ` MIke Galbraith
2006-02-27 9:07 ` Johannes Schindelin
2006-02-27 9:18 ` Andrew Morton
2006-02-27 23:18 ` Junio C Hamano
2006-02-27 23:29 ` Peter Williams
2006-02-28 0:10 ` Junio C Hamano
2006-02-27 23:37 ` Andrew Morton
2006-02-28 9:13 ` [PATCH] git-apply: war on whitespace -- finishing touches Junio C Hamano
2006-02-28 1:13 ` [PATCH 1/3] apply: squelch excessive errors and --whitespace=error-all Junio C Hamano
2006-02-28 1:13 ` [PATCH 2/3] apply --whitespace: configuration option Junio C Hamano
2006-02-28 9:16 ` Andreas Ericsson
2006-02-28 9:38 ` Junio C Hamano
2006-02-28 9:46 ` Andreas Ericsson
2006-02-28 1:13 ` [PATCH 3/3] git-apply --whitespace=nowarn Junio C Hamano
2006-02-28 3:26 ` A Large Angry SCM
2006-02-28 5:08 ` Junio C Hamano
2006-02-27 11:26 ` the war on trailing whitespace Adrien Beau
2006-02-27 11:41 ` Andreas Ericsson
2006-02-27 13:31 ` Uwe Zeisberger
2006-02-27 14:10 ` Andreas Ericsson
2006-02-27 14:31 ` Peter Hagervall
2006-02-27 14:40 ` Johannes Schindelin
2006-02-27 15:22 ` Randal L. Schwartz
2006-02-27 16:08 ` Josef Weidendorfer
2006-02-27 16:22 ` Adrien Beau
2006-02-27 16:37 ` Uwe Zeisberger
2006-02-27 16:41 ` Andreas Ericsson
2006-02-27 11:55 ` Johannes Schindelin
2006-02-27 0:45 ` Junio C Hamano
2006-02-27 2:14 ` [PATCH] apply --whitespace fixes and enhancements Junio C Hamano
2006-02-26 20:29 ` the war on trailing whitespace Junio C Hamano
2006-02-26 19:45 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2006-02-28 1:07 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060226202617.GH7851@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).