From: Petr Baudis <pasky@suse.cz>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: make gitfakemmap standalone to fix linking error in git.c
Date: Mon, 5 Dec 2005 15:11:41 +0100 [thread overview]
Message-ID: <20051205141141.GF22159@pasky.or.cz> (raw)
In-Reply-To: <81b0412b0512050524w7b632651n93c836fda41a39d@mail.gmail.com>
Dear diary, on Mon, Dec 05, 2005 at 02:24:47PM CET, I got a letter
where Alex Riesen <raa.lkml@gmail.com> said that...
> The patch is to fix the error introduced by previous patch, which
> inverted condition of checking for the supported case (start must be
> NULL).
>
> On 12/5/05, Alex Riesen <raa.lkml@gmail.com> wrote:
> > The patch is to fix linking error because of gitfakemmap referencing
> > die living in usage.c, and git.c not linking in the file. Instead of
> > hardcoding usage.o in git.c prerequisites, I separated mmap from the
> > main sources.
>
> Why does it always happen...
Possibly not worth yet another patch submission now, but in general I
believe it's better to send new revision of the original patch rather
than another patch on top of the previous one.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-12-05 14:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 13:19 make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 13:24 ` Alex Riesen
2005-12-05 14:11 ` Petr Baudis [this message]
2005-12-05 15:43 ` Alex Riesen
2005-12-05 17:40 ` Junio C Hamano
2005-12-05 20:22 ` [PATCH] Clean up compatibility definitions Junio C Hamano
2005-12-05 20:36 ` Johannes Schindelin
2005-12-05 20:51 ` Junio C Hamano
2005-12-05 21:39 ` Alex Riesen
2005-12-06 7:35 ` Alex Riesen
2005-12-06 7:58 ` Junio C Hamano
2005-12-05 21:50 ` Alex Riesen
2005-12-05 21:58 ` Junio C Hamano
2005-12-06 7:15 ` Alex Riesen
2005-12-06 7:31 ` Junio C Hamano
2005-12-06 8:07 ` Alex Riesen
2005-12-06 8:11 ` Junio C Hamano
2005-12-05 23:12 ` Petr Baudis
2005-12-06 3:17 ` Junio C Hamano
2005-12-06 9:53 ` Petr Baudis
2005-12-05 21:36 ` make gitfakemmap standalone to fix linking error in git.c Alex Riesen
2005-12-05 21:49 ` Junio C Hamano
2005-12-06 7:49 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205141141.GF22159@pasky.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).