From: Alexey Nezhdanov <snake@penza-gsm.ru>
To: David Mansfield <david@cobite.com>,
Matthias Urlichs <smurf@smurf.noris.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Added an option to cvsimport to specify email domain
Date: Fri, 30 Sep 2005 12:19:41 +0400 [thread overview]
Message-ID: <200509301219.42087.snake@penza-gsm.ru> (raw)
In-Reply-To: <1127825656.30421.15.camel@gandalf.cobite.com>
On Tuesday 27, September 2005 16:54 David Mansfield wrote:
> On Tue, 2005-09-27 at 08:34 +0400, Alexey Nezhdanov wrote:
> > (Re-post. Sorry for any inconvenience.)
> >
> > On September 14, 2005 23:34 Petr Baudis wrote:
> > > Dear diary, on Wed, Sep 07, 2005 at 09:18:03PM CEST, I got a letter
> > > where Junio C Hamano <junkio@cox.net> told me that...
> > >
> > > > David K?.A?Negedal <davidk@lysator.liu.se> writes:
> > > > > The authorship info in commits created by git-cvsimport-script
> > > > > only contains the username of the CVS committer. This patch
> > > > > adds a flag -e <domain> to git-cvsimport-script that makes it
> > > > > possible to specify an email domain that is added to all email
> > > > > addresses in the commit "author" and "committer" fields.
> > > > >
> > > > > ---
> > > > > I have stopped using cvsimport, because cvsps seems to produce bad
> > > > > output on the repository I'm using it with, but I had already
> > > > > prepared this patch.
> > > >
> > > > Hmph. One reason the original implementation did not do this is
> > > > because Linus and other people wanted to have a repeatability,
> > > > so making this an optional thing is good, but if we go this
> > > > route, I think if it would be nicer to have a --author-map
> > > > option that lets you feed a list of:
> > > >
> > > > <author> ==> "A U Thor <author@author.dom>"
> > > >
> > > > mappings, instead of a single -e, which essentially does not add
> > > > much information to the result.
> > > >
> > > > I take that your oob comment indicates that you do not have much
> > > > incentive/inclination to further hack on this, so I am not
> > > > asking you to do the above even if you find my suggestion
> > > > worthwhile.
> > >
> > > Various tools use CVSROOT/users to map usernames to realname <email>.
> > > I actually wanted to send a patch, looked at the cvsimport script and
> > > got totally scared away (at least for now)... ;-)
> >
> > git uses cvsps output to determine authorship. Do you think if this
> > problem should be solved on cvsps side? It should be relatively easy
> > IMHO. David, can you add another key to output CVSROOT/users mapping
> > result instead of usernames if available?
>
> I apologize that I probably won't have time to look at this right now...
>
> David
Hello. I have improved my patch and tested it with git-cvsimport-script.
cvsps works as intended so I hope that you, David will accept this patch. You can find it here:
http://www.penza-gsm.ru/snake/use_CVSROOT_users.patch
Though git-cvsimport-script not works as good as I wanted. It confuses with cvsps output like
Author: Alexey Nezhdanov <snakeru at users.sourceforge.net>
and converts it to something like
Alexey Nezhdanov snakeru at users.sourceforge.net <Alexey Nezhdanov snakeru at users.sourceforge.net>
Unfortunately I do not know perl so I can not write a patch for git-cvsimport-script.
So I asking you, Matthias, to help with this or may somebody on this list can do it instead.
--
Respectfully
Alexey Nezhdanov
next prev parent reply other threads:[~2005-09-30 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-07 8:00 [PATCH] Added an option to cvsimport to specify email domain David Kågedal
2005-09-07 19:18 ` Junio C Hamano
2005-09-14 19:34 ` Petr Baudis
2005-09-27 4:34 ` Alexey Nezhdanov
2005-09-27 12:54 ` David Mansfield
2005-09-30 8:19 ` Alexey Nezhdanov [this message]
2005-09-30 8:48 ` Junio C Hamano
2005-09-30 10:22 ` Alexey Nezhdanov
2005-09-30 13:54 ` David Mansfield
2005-09-29 10:26 ` Alexey Nezhdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509301219.42087.snake@penza-gsm.ru \
--to=snake@penza-gsm.ru \
--cc=david@cobite.com \
--cc=git@vger.kernel.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).