From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Nezhdanov Subject: Re: [PATCH] Added an option to cvsimport to specify email domain Date: Tue, 27 Sep 2005 08:34:55 +0400 Message-ID: <200509270834.55486.snake@penza-gsm.ru> References: <7vhdcw661g.fsf@assigned-by-dhcp.cox.net> <20050914193457.GE2936@pasky.or.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: David Mansfield X-From: git-owner@vger.kernel.org Tue Sep 27 06:37:27 2005 Return-path: Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EK7BI-00018K-5c for gcvg-git@gmane.org; Tue, 27 Sep 2005 06:35:05 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964800AbVI0Ee7 (ORCPT ); Tue, 27 Sep 2005 00:34:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964802AbVI0Ee7 (ORCPT ); Tue, 27 Sep 2005 00:34:59 -0400 Received: from host-80-95-32-178.leasedlines.sura.ru ([80.95.32.178]:13503 "HELO penza-gsm.ru") by vger.kernel.org with SMTP id S964800AbVI0Ee7 (ORCPT ); Tue, 27 Sep 2005 00:34:59 -0400 Received: (qmail 2683 invoked from network); 27 Sep 2005 04:35:47 -0000 Received: from unknown (HELO snake) (192.168.0.20) by fileserver.penza-gsm.ru with SMTP; 27 Sep 2005 04:35:47 -0000 To: git@vger.kernel.org User-Agent: KMail/1.7.2 In-Reply-To: <20050914193457.GE2936@pasky.or.cz> Content-Disposition: inline X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on fileserver X-Spam-Level: X-Spam-Status: No, score=-102.8 required=5.0 tests=ALL_TRUSTED,AWL, USER_IN_WHITELIST autolearn=unavailable version=3.0.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: (Re-post. Sorry for any inconvenience.) On September 14, 2005 23:34 Petr Baudis wrote: > Dear diary, on Wed, Sep 07, 2005 at 09:18:03PM CEST, I got a letter > where Junio C Hamano told me that... > > > David K?.A?Negedal writes: > > > The authorship info in commits created by git-cvsimport-script > > > only contains the username of the CVS committer. This patch > > > adds a flag -e to git-cvsimport-script that makes it > > > possible to specify an email domain that is added to all email > > > addresses in the commit "author" and "committer" fields. > > > > > > --- > > > I have stopped using cvsimport, because cvsps seems to produce bad > > > output on the repository I'm using it with, but I had already prepared > > > this patch. > > > > Hmph. One reason the original implementation did not do this is > > because Linus and other people wanted to have a repeatability, > > so making this an optional thing is good, but if we go this > > route, I think if it would be nicer to have a --author-map > > option that lets you feed a list of: > > > > ==> "A U Thor " > > > > mappings, instead of a single -e, which essentially does not add > > much information to the result. > > > > I take that your oob comment indicates that you do not have much > > incentive/inclination to further hack on this, so I am not > > asking you to do the above even if you find my suggestion > > worthwhile. > > Various tools use CVSROOT/users to map usernames to realname . > I actually wanted to send a patch, looked at the cvsimport script and > got totally scared away (at least for now)... ;-) git uses cvsps output to determine authorship. Do you think if this problem should be solved on cvsps side? It should be relatively easy IMHO. David, can you add another key to output CVSROOT/users mapping result instead of usernames if available? -- Respectfully Alexey Nezhdanov