From: Matthias Urlichs <smurf@smurf.noris.de>
To: Sven Verdoolaege <skimo@liacs.nl>
Cc: git@vger.kernel.org
Subject: [PATCH] cvsimport: Limit the log string to 32k
Date: Thu, 30 Jun 2005 18:38:50 +0200 [thread overview]
Message-ID: <20050630163850.GU10850@kiste.smurf.noris.de> (raw)
In-Reply-To: <20050630145528.GA18553@pc117b.liacs.nl>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
Teach the new cvsimport script to chop the log string's trailing whitespace.
Limit the log string to 32k, in order to be compatible with the old
cvs2git program.
Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
---
diff --git a/git-cvsimport-script b/git-cvsimport-script
--- a/git-cvsimport-script
+++ b/git-cvsimport-script
@@ -468,7 +468,12 @@ my $commit = sub {
}
$pw->writer();
$pr->reader();
- print $pw $logmsg
+
+ # compatibility with git2cvs
+ substr($logmsg,32767) = "" if length($logmsg) > 32767;
+ $logmsg =~ s/[\s\n]+\z//;
+
+ print $pw "$logmsg\n"
or die "Error writing to git-commit-tree: $!\n";
$pw->close();
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-06-30 16:32 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 19:23 [PATCH] cvsimport: rewritten in Perl Matthias Urlichs
2005-06-29 15:06 ` Nicolas Pitre
2005-06-29 20:40 ` Matthias Urlichs
2005-06-30 10:30 ` Matthias Urlichs
2005-06-30 16:48 ` Nicolas Pitre
2005-06-30 10:34 ` [PATCH] cvsimport-in-Perl: Limit the number of arguments to git-update-cache Matthias Urlichs
2005-06-30 16:54 ` Nicolas Pitre
2005-06-30 17:15 ` Nicolas Pitre
2005-06-30 18:02 ` Matthias Urlichs
2005-06-30 14:55 ` [PATCH] cvsimport: perform string comparison on "HEAD" Sven Verdoolaege
2005-06-30 15:21 ` Matthias Urlichs
2005-06-30 16:38 ` Matthias Urlichs [this message]
2005-06-30 15:02 ` [PATCH] cvsimport: rewritten in Perl Sven Verdoolaege
2005-06-30 15:21 ` Matthias Urlichs
2005-06-30 15:44 ` Sven Verdoolaege
2005-06-30 16:10 ` Matthias Urlichs
2005-06-30 16:14 ` Sven Verdoolaege
2005-06-30 16:30 ` Matthias Urlichs
2005-06-30 17:22 ` Nicolas Pitre
2005-07-01 9:43 ` Matthias Urlichs
2005-07-03 10:35 ` Sven Verdoolaege
2005-07-03 10:36 ` [PATCH] Make specification of CVS module to convert optional Sven Verdoolaege
2005-07-03 10:37 ` git-cvsimport-script: clean up documentation Sven Verdoolaege
2005-07-03 11:37 ` git-cvsimport-script: Honour CVS_SERVER Sven Verdoolaege
2005-07-03 11:38 ` [PATCH] git-cvsimport-script: Support :ext: access method Sven Verdoolaege
2005-07-03 12:21 ` cvsimport: rewritten in Perl Sven Verdoolaege
2005-07-03 13:44 ` Matthias Urlichs
2005-07-05 23:02 ` Wolfgang Denk
2005-07-06 2:41 ` Linus Torvalds
2005-07-06 6:37 ` Sven Verdoolaege
2005-07-06 7:32 ` Matthias Urlichs
2005-07-06 10:24 ` Wolfgang Denk
2005-07-04 12:13 ` [PATCH] git-cvsimport-script: leave working directory alone Sven Verdoolaege
2005-07-04 12:13 ` [PATCH] git-cvsimport-script: use private index Sven Verdoolaege
2005-07-04 14:06 ` [PATCH] git-cvsimport-script: fix branch switching Sven Verdoolaege
2005-07-04 14:09 ` [PATCH] git-cvsimport-script: update cvsps cache instead of rebuilding it Sven Verdoolaege
2005-06-30 19:38 ` [PATCH] cvsimport: rewritten in Perl Sven Verdoolaege
2005-06-30 21:00 ` Matthias Urlichs
2005-07-01 7:01 ` Sven Verdoolaege
2005-07-01 7:25 ` Matthias Urlichs
2005-07-04 13:03 ` Sven Verdoolaege
2005-07-04 13:53 ` Matthias Urlichs
2005-07-04 13:46 ` Sven Verdoolaege
2005-07-04 14:36 ` Matthias Urlichs
2005-07-04 15:52 ` Sven Verdoolaege
2005-07-03 23:03 ` Sven Verdoolaege
2005-07-04 1:49 ` Matthias Urlichs
2005-07-04 10:47 ` Sven Verdoolaege
2005-06-30 18:48 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050630163850.GU10850@kiste.smurf.noris.de \
--to=smurf@smurf.noris.de \
--cc=git@vger.kernel.org \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).