From: Petr Baudis <pasky@ucw.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Sean <seanlkml@sympatico.ca>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [RFC] Renaming environment variables.
Date: Tue, 10 May 2005 02:25:48 +0200 [thread overview]
Message-ID: <20050510002548.GI15712@pasky.ji.cz> (raw)
In-Reply-To: <7vhdhcxj0z.fsf_-_@assigned-by-dhcp.cox.net>
Dear diary, on Mon, May 09, 2005 at 10:05:00PM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> told me that...
> - Renames the following environment variables:
>
> New name Old Name
>
> GIT_AUTHOR_DATE AUTHOR_DATE
> GIT_AUTHOR_EMAIL AUTHOR_EMAIL
> GIT_AUTHOR_NAME AUTHOR_NAME
> GIT_COMMIT_AUTHOR_EMAIL COMMIT_AUTHOR_EMAIL
> GIT_COMMIT_AUTHOR_NAME COMMIT_AUTHOR_NAME
> GIT_ALTERNATE_OBJECTS SHA1_FILE_DIRECTORIES
> GIT_OBJECTS SHA1_FILE_DIRECTORY
Could I please have s/COMMIT_AUTHOR/COMMITTER/ and
s/OBJECTS/(OBJDIR|OBJECT_DIR)/?
> The transition plan is as follows:
>
> - We will keep the backward compatibility list used by gitenv()
> for now, so the current scripts and user environments
> continue to work as before. The users will get warnings when
> they have old name but not new name in their environment to
> the stderr.
>
> - The Porcelain layers should start using new names. However,
> just in case it ends up calling old Plumbing layer
> implementation, they should also export old names, taking
> values from the corresponding new names, during the
> transition period.
(Cogito needs its own git-merge-cache so that the merge goes properly
anyway, and it already (or still) carries its Git around, so I think
it's not applicable to it. Yes, I want and plan to start publishing the
Git changes, I'm already making some steps for that and I hope I have
something to show by tomorrow.)
> - After a couple of weeks or so, we would drop the
> compatibility support and drop gitenv(). Revert the callers
> to directly call getenv() but keep using the new names.
>
> The last part is probably optional and the transition
> duration needs to be set to a reasonable value.
Yes, I think couple of weeks is too long. :-) I'd say one or two
releases is enough.
> --- /dev/null
> +++ b/gitenv.c
Pretty please, add copyright notices at the top of files.
> +char *gitenv_bc(const char *e)
> +{
> + int first, last;
> + char *val = getenv(e);
> + if (val)
> + /* inefficient. caller should use gitenv() not gitenv_bc() */
> + return val;
Can this ever happen? If doing it at all, I'd expect gitenv_bc() to
rather freak out and die(), the caller is broken.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
next prev parent reply other threads:[~2005-05-10 0:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 23:35 [PATCH] Introduce SHA1_FILE_DIRECTORIES Junio C Hamano
2005-05-07 0:20 ` Sean
2005-05-07 0:24 ` Junio C Hamano
2005-05-07 0:32 ` Sean
2005-05-07 6:31 ` Junio C Hamano
2005-05-07 19:51 ` Junio C Hamano
2005-05-09 13:33 ` H. Peter Anvin
2005-05-09 16:38 ` Junio C Hamano
2005-05-09 16:41 ` Sean
2005-05-09 18:03 ` H. Peter Anvin
2005-05-09 18:50 ` Junio C Hamano
2005-05-09 20:05 ` [RFC] Renaming environment variables Junio C Hamano
2005-05-09 20:15 ` Thomas Glanzmann
2005-05-10 0:32 ` Petr Baudis
2005-05-09 21:04 ` Sean
2005-05-09 23:08 ` Daniel Barkalow
2005-05-10 0:09 ` Junio C Hamano
2005-05-10 0:13 ` Petr Baudis
2005-05-10 0:22 ` Junio C Hamano
2005-05-10 0:27 ` Petr Baudis
2005-05-10 0:38 ` Daniel Barkalow
2005-05-10 0:44 ` Petr Baudis
2005-05-10 0:53 ` Daniel Barkalow
2005-05-10 5:45 ` Junio C Hamano
2005-05-10 6:25 ` Introducing GIT_DIR environment variable Junio C Hamano
2005-05-10 23:39 ` Alex Riesen
2005-05-10 2:16 ` [RFC] Renaming environment variables Junio C Hamano
2005-05-10 3:23 ` Daniel Barkalow
2005-05-10 0:25 ` Petr Baudis [this message]
2005-05-10 1:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050510002548.GI15712@pasky.ji.cz \
--to=pasky@ucw.cz \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=junkio@cox.net \
--cc=seanlkml@sympatico.ca \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).