From: Jonas Fonseca <fonseca@diku.dk>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix memory leaks in read_tree_recursive()
Date: Thu, 5 May 2005 02:08:15 +0200 [thread overview]
Message-ID: <20050505000815.GA25992@diku.dk> (raw)
In-Reply-To: <7vpsw6muay.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote Wed, May 04, 2005:
> >>>>> "JF" == Jonas Fonseca <fonseca@diku.dk> writes:
>
> JF> This patch fixes memory leaks in the error path of
> JF> read_tree_recursive().
>
> The leak seems to be real but what is "mem_free"?
That mem_free() was a bad habbit from the project I usually work on.
> Has it been compile tested?
No, but the second patch has.
BTW, when compiling git on a FreeBSD box I get these warnings:
date.c: In function `parse_date':
date.c:414: warning: long unsigned int format, time_t arg (arg 4)
date.c:414: warning: long unsigned int format, time_t arg (arg 4)
date.c: In function `datestamp':
date.c:427: warning: long unsigned int format, time_t arg (arg 4)
date.c:427: warning: long unsigned int format, time_t arg (arg 4)
tar-tree.c: In function `write_header':
tar-tree.c:249: warning: long unsigned int format, time_t arg (arg 3)
local-pull.c: In function `fetch':
local-pull.c:73: warning: long int format, different type arg (arg 4)
because time_t is defined as int32_t. Don't know if they are worth
fixing at this point.
> JF> @@ -39,14 +39,18 @@
> JF> if (S_ISDIR(mode)) {
> JF> int retval;
>
> JF> ...
> JF> - if (!eltbuf || strcmp(elttype, "tree"))
> JF> + if (!eltbuf || strcmp(elttype, "tree")) {
> JF> + if (eltbuf) mem_free(eltbuf);
> JF> return -1;
>
> Btw, who is putting this header in your mail? It does not make
> sense to me unless Jonas is pseudonym for Linus...
>
> Mail-Followup-To: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org
Maybe because Mutt knows I am subscribe to this mailing list and assumes
I don't want to have mail addressed directly to my email address?
I just hit 'g'.
--
Jonas Fonseca
prev parent reply other threads:[~2005-05-05 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 23:19 [PATCH] Fix memory leaks in read_tree_recursive() Jonas Fonseca
2005-05-04 23:39 ` Jonas Fonseca
2005-05-04 23:43 ` Junio C Hamano
2005-05-05 0:08 ` Jonas Fonseca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050505000815.GA25992@diku.dk \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).