From: lists@haller-berlin.de (Stefan Haller)
To: gitster@pobox.com (Junio C Hamano)
Cc: anatoly.borodin@gmail.com (Anatoly Borodin), git@vger.kernel.org
Subject: Re: Limitiations of git rebase --preserve-merges --interactive
Date: Fri, 23 Sep 2016 17:50:41 +0200 [thread overview]
Message-ID: <1mu1iqo.1gihw0m1dcenmnM%lists@haller-berlin.de> (raw)
In-Reply-To: <xmqqvaxm1vc3.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> lists@haller-berlin.de (Stefan Haller) writes:
>
> > Thanks, this is interesting; I'm having trouble understanding the tests
> > though. Some of them use rebase -p -i, but I don't understand why they
> > use -i, or why that even works in a test (i.e. why it doesn't open an
> > editor).
>
> Upon starting up, tests dot-source t/test-lib.sh file and it
> unsets most of GIT_* environment variables to obtain a stable
> testing environment that is not affected by things that testers
> may have in their environment.
>
> There is EDITOR=: in t/test-lib.sh, which was added in 2006 before
> GIT_EDITOR was invented. That is the one in effect for git
> subcommands that usually interacts with editors during the test,
> unless specific tests further override it with test_set_editor
> helper.
Thanks for the explanation. So this explains why -i works at all here;
it doesn't explain why -i is used in these tests. Unless I'm missing
something, they should all work with just -p.
And I don't see any tests that do rebase -p -i and actually do something
interesting with the -i part. So my original question still remains. :-)
--
Stefan Haller
Berlin, Germany
http://www.haller-berlin.de/
next prev parent reply other threads:[~2016-09-23 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 8:46 Limitiations of git rebase --preserve-merges --interactive Stefan Haller
2016-09-22 19:33 ` Anatoly Borodin
2016-09-22 19:48 ` Kevin Daudt
2016-09-22 20:54 ` Stefan Beller
2016-09-23 10:40 ` Stefan Haller
2016-09-23 21:13 ` Johannes Schindelin
2016-09-23 22:26 ` Stefan Beller
2016-09-22 21:04 ` Anatoly Borodin
2016-09-22 21:01 ` Anatoly Borodin
2016-09-22 21:08 ` Stefan Beller
2016-09-23 21:04 ` Johannes Schindelin
2016-09-23 10:40 ` Stefan Haller
2016-09-23 15:37 ` Junio C Hamano
2016-09-23 15:50 ` Stefan Haller [this message]
2016-09-23 19:24 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1mu1iqo.1gihw0m1dcenmnM%lists@haller-berlin.de \
--to=lists@haller-berlin.de \
--cc=anatoly.borodin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).