git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Adam Sharafeddine <adam.shrfdn@gmail.com>, git@vger.kernel.org
Subject: Re: Wrong configuration variable mentioned in git-push documentation (examples section)
Date: Thu, 25 Feb 2021 08:57:53 -0500	[thread overview]
Message-ID: <1fd7d816-1572-8563-1c4d-4be83926e4a2@gmail.com> (raw)
In-Reply-To: <CAAxrY9yjTKV8-K0AmO4fBmtDrSB4KkN_xKOMmtSb-dvixJNaEQ@mail.gmail.com>

Hi Adam,

Le 2021-02-22 à 00:07, Adam Sharafeddine a écrit :
> Hello
> 
> In the file Documentation/git-push.txt under the EXAMPLES section,
> specifically under
> `git push origin`::, remote.origin.merge configuration variable is
> said to configure the
> upstream branch for the origin remote, when in fact it should be
> branch.<name>.merge,
> where <name> is the name of the local branch at which HEAD is
> currently pointing to.
> 
> Here's en excerpt:
> 
>> `git push origin`::
>>          Without additional configuration, pushes the current branch to
>>          the configured upstream (`remote.origin.merge` configuration
>>          variable) if it has the same name as the current branch, and
>>          errors out without pushing otherwise.
> 
> 
> I'm still learning Git so I thought I would share this with you (I got
> confused reading
> the examples). Maybe I'll learn something new or/and correct the
> aforementioned error.
> 

You are completely right, that example seems to use an old and now non-existent
(at least, undocumented in git-config(1) [1]) configuration variable.
I encourage you to fix it yourself and submit a patch :) See [2] for a nice tutorial on
how to do this if you are interested.

Cheers,
Philippe.


[1] https://git-scm.com/docs/git-config
[2] https://git-scm.com/docs/MyFirstContribution

      reply	other threads:[~2021-02-25 14:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22  5:07 Adam Sharafeddine
2021-02-25 13:57 ` Philippe Blain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fd7d816-1572-8563-1c4d-4be83926e4a2@gmail.com \
    --to=levraiphilippeblain@gmail.com \
    --cc=adam.shrfdn@gmail.com \
    --cc=git@vger.kernel.org \
    --subject='Re: Wrong configuration variable mentioned in git-push documentation (examples section)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).