From: "Nipunn Koorapati via GitGitGadget" <gitgitgadget@gmail.com> To: git@vger.kernel.org Cc: Eric Sunshine <sunshine@sunshineco.com>, Nipunn Koorapati <nipunn1313@gmail.com>, Nipunn Koorapati <nipunn@dropbox.com> Subject: [PATCH v5 2/2] negative-refspec: improve comment on query_matches_negative_refspec Date: Tue, 22 Dec 2020 03:58:17 +0000 Message-ID: <1f9af0e991c0b84cd00641322f2d76bdc8fbeb29.1608609498.git.gitgitgadget@gmail.com> (raw) In-Reply-To: <pull.820.v5.git.1608609498.gitgitgadget@gmail.com> From: Nipunn Koorapati <nipunn@dropbox.com> Comment did not adequately explain how the two loops work together to achieve the goal of querying for matching of any negative refspec. Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com> --- remote.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/remote.c b/remote.c index 4f1a4099f1a..4d150a316ed 100644 --- a/remote.c +++ b/remote.c @@ -736,6 +736,12 @@ static int query_matches_negative_refspec(struct refspec *rs, struct refspec_ite * item uses the destination. To handle this, we apply pattern * refspecs in reverse to figure out if the query source matches any * of the negative refspecs. + * + * The first loop finds and expands all positive refspecs + * matched by the queried ref. + * + * The second loop checks if any of the results of the first loop + * match any negative refspec. */ for (i = 0; i < rs->nr; i++) { struct refspec_item *refspec = &rs->items[i]; -- gitgitgadget
next prev parent reply other threads:[~2020-12-22 4:00 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-19 17:23 [PATCH] negative-refspec: fix segfault on : refspec Nipunn Koorapati via GitGitGadget 2020-12-19 18:05 ` Junio C Hamano 2021-02-19 9:28 ` Jacob Keller 2020-12-19 21:58 ` [PATCH v2 0/2] " Nipunn Koorapati via GitGitGadget 2020-12-19 21:58 ` [PATCH v2 1/2] " Nipunn Koorapati via GitGitGadget 2020-12-20 2:57 ` Eric Sunshine 2020-12-19 21:58 ` [PATCH v2 2/2] negative-refspec: improve comment on query_matches_negative_refspec Nipunn Koorapati via GitGitGadget 2020-12-21 2:05 ` [PATCH v3 0/3] negative-refspec: fix segfault on : refspec Nipunn Koorapati via GitGitGadget 2020-12-21 2:05 ` [PATCH v3 1/3] test-lib-functions: handle --add in test_config Nipunn Koorapati via GitGitGadget 2020-12-21 7:07 ` Eric Sunshine 2020-12-21 19:00 ` Junio C Hamano 2020-12-21 20:08 ` Eric Sunshine 2020-12-22 0:00 ` Nipunn Koorapati 2020-12-22 0:13 ` Eric Sunshine 2020-12-22 2:25 ` Nipunn Koorapati 2020-12-22 5:19 ` Eric Sunshine 2020-12-21 2:05 ` [PATCH v3 2/3] negative-refspec: fix segfault on : refspec Nipunn Koorapati via GitGitGadget 2020-12-21 7:20 ` Eric Sunshine 2020-12-21 2:05 ` [PATCH v3 3/3] negative-refspec: improve comment on query_matches_negative_refspec Nipunn Koorapati via GitGitGadget 2020-12-22 1:11 ` [PATCH v4 0/2] negative-refspec: fix segfault on : refspec Nipunn Koorapati via GitGitGadget 2020-12-22 1:11 ` [PATCH v4 1/2] " Nipunn Koorapati via GitGitGadget 2020-12-22 2:08 ` Junio C Hamano 2020-12-22 2:28 ` Junio C Hamano 2020-12-22 1:11 ` [PATCH v4 2/2] negative-refspec: improve comment on query_matches_negative_refspec Nipunn Koorapati via GitGitGadget 2020-12-22 3:58 ` [PATCH v5 0/2] negative-refspec: fix segfault on : refspec Nipunn Koorapati via GitGitGadget 2020-12-22 3:58 ` [PATCH v5 1/2] " Nipunn Koorapati via GitGitGadget 2021-02-19 9:32 ` Jacob Keller 2020-12-22 3:58 ` Nipunn Koorapati via GitGitGadget [this message] 2020-12-22 6:48 ` [PATCH v5 0/2] " Junio C Hamano 2020-12-23 23:56 ` Nipunn Koorapati 2020-12-24 0:00 ` Junio C Hamano 2021-01-11 20:22 ` Nipunn Koorapati 2021-01-12 2:01 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1f9af0e991c0b84cd00641322f2d76bdc8fbeb29.1608609498.git.gitgitgadget@gmail.com \ --to=gitgitgadget@gmail.com \ --cc=git@vger.kernel.org \ --cc=nipunn1313@gmail.com \ --cc=nipunn@dropbox.com \ --cc=sunshine@sunshineco.com \ --subject='Re: [PATCH v5 2/2] negative-refspec: improve comment on query_matches_negative_refspec' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git