git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Sebastian Schuberth <sschuberth@gmail.com>
To: git@vger.kernel.org
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore
Date: Tue, 21 Mar 2017 10:14:06 +0100	[thread overview]
Message-ID: <1f14be35-4688-7d0b-bb84-bfc901dba807@gmail.com> (raw)
In-Reply-To: <CAGZ79kY7bCt_3Fse_Qi43Aej=MgN1ABLTx7eLmPCs+aP2e9ZwQ@mail.gmail.com>

On 3/20/2017 18:43, Stefan Beller wrote:

>> With this version, when I do a "reword" during an inteactive rebase session,
>> the commit-msg hook doe snot seem to be triggered anymore. This was
>> particularly useful to let Gerrit's commit-msg hook add missing ChangeId
>> footers.
>>
>> I can work-aorund the issue by doing an "edit" and "commit --amend".
>>
>> Is anyone else seeing this?
>
> In 2.12 RelNotes:
>
>  * "git rebase -i" starts using the recently updated "sequencer" code.

Thanks, that looks like a possible culprit. I can *not* reproduce the 
issue on Linux with "git version 2.12.1-382-gc0f9c70", thought. So 
either it's Windows-specific, or it has been fixed in 2.12.1 already.

Regards,
Sebastian




      reply	other threads:[~2017-03-21  9:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 15:50 Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore Sebastian Schuberth
2017-03-20 17:43 ` Stefan Beller
2017-03-21  9:14   ` Sebastian Schuberth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f14be35-4688-7d0b-bb84-bfc901dba807@gmail.com \
    --to=sschuberth@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).