From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0D9BC1F461 for ; Sat, 24 Aug 2019 13:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727619AbfHXN7E (ORCPT ); Sat, 24 Aug 2019 09:59:04 -0400 Received: from smtp.hosts.co.uk ([85.233.160.19]:56718 "EHLO smtp.hosts.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727546AbfHXN7E (ORCPT ); Sat, 24 Aug 2019 09:59:04 -0400 Received: from [92.7.169.237] (helo=[192.168.1.22]) by smtp.hosts.co.uk with esmtpa (Exim) (envelope-from ) id 1i1WZI-0002hl-Cg; Sat, 24 Aug 2019 14:59:01 +0100 Subject: Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option To: Denton Liu , Junio C Hamano Cc: Git Mailing List , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Eric Sunshine References: <20190823181545.GA14048@archbookpro.localdomain> <20190824080328.GA9726@archbookpro.localdomain> From: Philip Oakley Message-ID: <1eccefe4-8002-4664-3bc2-8332fb7bd697@iee.email> Date: Sat, 24 Aug 2019 14:59:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190824080328.GA9726@archbookpro.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 24/08/2019 09:03, Denton Liu wrote: > On Fri, Aug 23, 2019 at 01:18:44PM -0700, Junio C Hamano wrote: >> Philip Oakley writes: >> >>> Perhaps the `--infer-cover-subject` the config option needs to be >>> multi-valued to include: >>>      "subject" (always expect short first lines) or >>>      "message" (always the long paragraph description, still use >>> ***Subject Here***), >>>      with the "true" being used when expecting both as previously >>> described. > Good idea, I like this a lot! > >> The idea to have three choices feels that this is getting better, >> but I notice that the choice is no longer about "subject". >> >> I've always felt that the name of this option is way suboptimal. >> One reason is because the option only says it is about the subject >> of the cover (letter), and the verb "infer" conveys almost no >> information---especially it does not say anything about what affects >> the inference (hint: the branch description value gets used, in a >> single hardcoded ways right now, but now with the patch we have a >> choice to control how it gets used). > Perhaps something like > --cover-subject-from-description={true,auto,false}? maybe --cover-letter-from-description={true,auto,subject,message,false}? to cover most eventualities (i.e. letter rather than subject). I haven't looked at what happens on Windows (CRLF usage?) for multi-line descriptions. The common assumption is LF in repo, with attributes etc, but the branch description is a bit free format in terms of guidance ;-) Philip