From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id AFEFD20373 for ; Mon, 13 Mar 2017 20:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275AbdCMUNI (ORCPT ); Mon, 13 Mar 2017 16:13:08 -0400 Received: from fester.cwi.nl ([192.16.191.27]:37654 "EHLO fester.cwi.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbdCMUNG (ORCPT ); Mon, 13 Mar 2017 16:13:06 -0400 Received: from fester.cwi.nl (fester.cwi.nl [192.16.191.27]) by fester.cwi.nl (8.14.4/8.12.3) with ESMTP id v2DKCerA021638; Mon, 13 Mar 2017 21:12:40 +0100 Received: from [192.168.4.61] (541FB48C.cm-5-8c.dynamic.ziggo.nl [84.31.180.140]) (authenticated bits=0) by fester.cwi.nl (8.14.4/8.12.3) with ESMTP id v2DKCdYP021630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 13 Mar 2017 21:12:40 +0100 Subject: Re: [PATCH] Put sha1dc on a diet To: Jeff King , Dan Shumow References: <20170301195302.3pybakmjqztosohj@sigill.intra.peff.net> <20170301203427.e5xa5ej3czli7c3o@sigill.intra.peff.net> <20170313151322.ouryghyb5orkpk5g@sigill.intra.peff.net> <20170313194848.2z2dlgpomu6e3dkh@sigill.intra.peff.net> Cc: Linus Torvalds , Junio C Hamano , Git Mailing List From: Marc Stevens Message-ID: <1e6a592f-7da1-8043-0b29-0bb7c8cda3f3@cwi.nl> Date: Mon, 13 Mar 2017 21:12:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170313194848.2z2dlgpomu6e3dkh@sigill.intra.peff.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Indeed, I've committed a fix, and a small bug fix for the new code just now. The merge incorrectly removed some control logic, which caused more unnecessary checks to happen. I already marked this in the PR, but committed a fix only today. BTW as noted in the Readme, the theoretic false positive probability is <<2^-90, almost non-existent. Best regards, Marc Stevens On 3/13/2017 8:48 PM, Jeff King wrote: > On Mon, Mar 13, 2017 at 07:42:17PM +0000, Dan Shumow wrote: > >> Marc just made a commit this morning fixing problems with the merge. >> Please give the latest in feature/performance a try, as that seems to >> eliminate the problem. > Yeah, b17728507 makes the problem go away for me. Thanks. > > FWIW, I have all sha1s on github.com running through this right now > (actually, the ad744c8b7 version), and logging any false-positives on > the collision detection. Nothing so far, after a few hours. > > -Peff