From: Harish Karumuthil <harish2704@gmail.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts
Date: Mon, 07 Oct 2019 11:43:06 +0530 [thread overview]
Message-ID: <1dbb69d96229fa9400d7eae0b4fd467ab9706815.camel@gmail.com> (raw)
In-Reply-To: <20191005210127.uinrgazj5ezyqftj@yadavpratyush.com>
Hi Pratyush, Regarding your messages,
>On Sun, 2019-10-06 at 02:31 +0530, Pratyush Yadav wrote:
> You don't need to "set up" an email client with git-send-email.
> git-send-email is an email client itself. Well, one which can only send
> emails.
For now, I am sticking with a mail client ( evolution ) which does minimal
( or atleast transparent ) preprocessing ( Tab => space conversion , line
wrapping etc ).
Now I can send patches using the output of `git diff --patch-with-stat`
command and I hope is it enough for now.
Personaly I dont' like any solution which requires storing our mail password
as a plain text file.
> You haven't sent '/submit' over there, so those emails aren't in the
> list (and my inbox) yet. You need to comment with '/submit' (without the
> quotes) to tell GitGitGadget to send your PR as email.
I thought, lets finalize discussion about all the changes here in mail
thread it self before submitting the patch. Otherwise, That is why I didn't
submitted the patch.
> One point I forgot to mention earlier was that I'm honestly not a big
> fan of separating the binding and accelerator label. I understand that
> you might not have the time to do this, but I think it is still worth
> mentioning. Maybe I will implement something like that over your patch.
> But it would certainly be nice if you can figure it out :).
I think there is a small missunderstanind in that point.
I agree that, in the initial implementation ( which I did @ 2016 ) menu
labels were separated from binding keys. But in the last update, it is not
like that.
Currently, user only need to specify single config value which is
`guitool.<name>.gitgui-shortcut` and don't have to specify accel-lable
separatly.
Label is generated from the shortcut.
> Either ways, detecting an existing shortcut is pretty easy. The `bind`
> man page [1] says:
>
> If sequence is specified without a script, then the script currently
> bound to sequence is returned, or an empty string is returned if there
> is no binding for sequence.
>
> So you can use this to find out if there is a binding conflict, and warn
> the user.
Will try this. Thanks!
next prev parent reply other threads:[~2019-10-07 6:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 11:38 [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts Harish K
2016-03-31 16:41 ` David Aguilar
2016-04-01 6:32 ` harish k
2019-10-03 14:48 ` harish k
2019-10-03 21:44 ` Pratyush Yadav
2019-10-04 8:49 ` Johannes Schindelin
2019-10-04 12:01 ` Pratyush Yadav
2019-10-05 20:16 ` Harish Karumuthil
2019-10-05 21:01 ` Pratyush Yadav
2019-10-06 9:49 ` Johannes Schindelin
2019-10-06 18:39 ` Pratyush Yadav
2019-10-06 19:37 ` Philip Oakley
2019-10-06 20:27 ` Johannes Schindelin
2019-10-06 21:06 ` Pratyush Yadav
2019-10-07 9:20 ` GitGUIGadget, was " Johannes Schindelin
2019-10-07 10:43 ` Birger Skogeng Pedersen
2019-10-07 19:16 ` Alban Gruin
2019-11-19 22:09 ` Making GitGitGadget's list -> PR comment mirroring bidirectional, " Johannes Schindelin
2019-11-20 14:22 ` Pratyush Yadav
2019-10-06 22:40 ` Philip Oakley
2019-10-07 6:22 ` Harish Karumuthil
2019-10-07 10:01 ` Johannes Schindelin
2019-10-08 19:31 ` Harish Karumuthil
2019-10-09 20:42 ` Johannes Schindelin
2019-10-13 20:09 ` Pratyush Yadav
2019-10-07 6:13 ` Harish Karumuthil [this message]
2019-10-13 19:17 ` Pratyush Yadav
-- strict thread matches above, loose matches on Subject: below --
2016-03-29 11:29 Harish K
2016-03-31 16:49 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dbb69d96229fa9400d7eae0b4fd467ab9706815.camel@gmail.com \
--to=harish2704@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).