From: Sibo Dong <sibo.dong@mail.utoronto.ca>
To: "gitster@pobox.com" <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"gitgitgadget@gmail.com" <gitgitgadget@gmail.com>,
"sibo.dong@outlook.com" <sibo.dong@outlook.com>
Subject: Re: [PATCH] git-prompt.sh: make `option` a local variable
Date: Sun, 1 Nov 2020 08:04:04 +0000 [thread overview]
Message-ID: <1d19cdf35c12b1079cee0861469dc1a652642c82.camel@mail.utoronto.ca> (raw)
In-Reply-To: <xmqqmu02xbe6.fsf@gitster.c.googlers.com>
Thank you for the feedback Junio; I'm a bit new to contributing. Since
you've justified this change much better than I have, is there any need
for further action on my part?
--
Sibo Dong <sibo.dong@mail.utoronto.ca>
next prev parent reply other threads:[~2020-11-01 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 22:09 [PATCH] git-prompt.sh: make `option` a local variable Sibo Dong via GitGitGadget
2020-10-31 22:45 ` Junio C Hamano
2020-11-01 8:04 ` Sibo Dong [this message]
2020-11-02 20:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d19cdf35c12b1079cee0861469dc1a652642c82.camel@mail.utoronto.ca \
--to=sibo.dong@mail.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=sibo.dong@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).