git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Alex Henrie <alexhenrie24@gmail.com>,
	git@vger.kernel.org, pc44800@gmail.com, chriscool@tuxfamily.org,
	stefanbeller@gmail.com, kaartic.sivaraam@gmail.com,
	Johannes.Schindelin@gmx.de, shouryashukla.oo@gmail.com,
	gitster@pobox.com
Subject: Re: [PATCH] submodule: use the imperative mood to describe the --files option
Date: Mon, 17 May 2021 12:58:03 +0700	[thread overview]
Message-ID: <1cfb25fd-1ef9-864c-bbb3-bab0a5676728@gmail.com> (raw)
In-Reply-To: <20210516215957.33341-1-alexhenrie24@gmail.com>

Hi Alex,

On 17/05/21 04.59, Alex Henrie wrote:
> -			 N_("to compare the commit in the index with that in the submodule HEAD")),
> +			 N_("compare the commit in the index with that in the submodule HEAD")),

Seems correct.

FYI, on my native language (Indonesian), we say "Review yourself" as
"Tinjau dirimu" for imperative mood. Unfortunately many imperative
sentences on software l10n instead prefix the verb with "me-", such as
"meninjau dirimu". That is not imperative mood; that is descriptive
mood with infinitive verb form.

Anyway, thanks.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

  reply	other threads:[~2021-05-17  5:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 21:59 [PATCH] submodule: use the imperative mood to describe the --files option Alex Henrie
2021-05-17  5:58 ` Bagas Sanjaya [this message]
2021-05-17  6:56 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cfb25fd-1ef9-864c-bbb3-bab0a5676728@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=alexhenrie24@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=pc44800@gmail.com \
    --cc=shouryashukla.oo@gmail.com \
    --cc=stefanbeller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).