From: Teng Long <dyroneteng@gmail.com> To: dyroneteng@gmail.com Cc: avarab@gmail.com, derrickstolee@github.com, git@vger.kernel.org, me@ttaylorr.com, tenglong.tl@alibaba-inc.com, gitster@pobox.com Subject: [PATCH v2 1/5] pack-bitmap.c: continue looping when first MIDX bitmap is found Date: Thu, 21 Apr 2022 21:26:36 +0800 [thread overview] Message-ID: <1bfd2fb6ab01af689fc6495e2f32d3f64c19f4b7.1650547400.git.dyroneteng@gmail.com> (raw) In-Reply-To: <cover.1650547400.git.dyroneteng@gmail.com> In "open_midx_bitmap()", we do a loop with the MIDX(es) in repo, when the first one has been found, then will break out by a "return" directly. But actually, it's better to don't stop the loop until we have visited both the MIDX in our repository, as well as any alternates (along with _their_ alternates, recursively). The discussion link of community: https://public-inbox.org/git/YjzCTLLDCby+kJrZ@nand.local/ Helped-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Teng Long <dyroneteng@gmail.com> --- pack-bitmap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pack-bitmap.c b/pack-bitmap.c index 9c666cdb8b..112c2b12c6 100644 --- a/pack-bitmap.c +++ b/pack-bitmap.c @@ -494,15 +494,16 @@ static int open_pack_bitmap(struct repository *r, static int open_midx_bitmap(struct repository *r, struct bitmap_index *bitmap_git) { + int ret = -1; struct multi_pack_index *midx; assert(!bitmap_git->map); for (midx = get_multi_pack_index(r); midx; midx = midx->next) { if (!open_midx_bitmap_1(bitmap_git, midx)) - return 0; + ret = 0; } - return -1; + return ret; } static int open_bitmap(struct repository *r, -- 2.35.1.583.g30faa5f068
next prev parent reply other threads:[~2022-04-21 13:27 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-24 11:43 [PATCH v1 0/3] trace2 output for bitmap decision path Teng Long 2022-03-24 11:43 ` [PATCH v1 1/3] pack-bitmap.c: use "ret" in "open_midx_bitmap()" Teng Long 2022-03-24 19:11 ` Taylor Blau 2022-03-28 7:59 ` [PATCH v1 1/3] pack-bitmap.c: use "ret" in "open_midx_bitmap() Teng Long 2022-03-30 2:39 ` Taylor Blau 2022-03-24 11:44 ` [PATCH v1 2/3] pack-bitmap.c: add "break" statement in "open_pack_bitmap()" Teng Long 2022-03-24 18:40 ` Junio C Hamano 2022-03-24 19:06 ` Taylor Blau 2022-03-24 19:03 ` Taylor Blau 2022-03-29 2:49 ` Teng Long 2022-03-30 2:55 ` Taylor Blau 2022-03-30 7:32 ` Teng Long Teng Long 2022-03-30 13:17 ` Ævar Arnfjörð Bjarmason 2022-03-24 11:44 ` [PATCH v1 3/3] bitmap: add trace outputs during open "bitmap" file Teng Long 2022-03-24 18:42 ` Junio C Hamano 2022-03-24 13:22 ` [PATCH v1 0/3] trace2 output for bitmap decision path Ævar Arnfjörð Bjarmason 2022-03-29 7:38 ` Teng Long Teng Long 2022-03-29 8:54 ` Ævar Arnfjörð Bjarmason 2022-04-21 13:26 ` [PATCH v2 0/5] trace2 output for bitmap decision path Teng Long 2022-04-21 13:26 ` Teng Long [this message] 2022-05-11 21:31 ` [PATCH v2 1/5] pack-bitmap.c: continue looping when first MIDX bitmap is found Taylor Blau 2022-04-21 13:26 ` [PATCH v2 2/5] pack-bitmap.c: rename "idx_name" to "bitmap_name" Teng Long 2022-05-11 21:31 ` Taylor Blau 2022-04-21 13:26 ` [PATCH v2 3/5] pack-bitmap.c: make warnings more detailed when opening bitmap Teng Long 2022-04-21 17:25 ` Taylor Blau 2022-05-06 9:08 ` Teng Long 2022-04-21 13:26 ` [PATCH v2 4/5] bitmap: add trace2 outputs during open "bitmap" file Teng Long 2022-04-21 15:51 ` Ævar Arnfjörð Bjarmason 2022-05-06 11:27 ` Teng Long 2022-05-06 11:53 ` Teng Long 2022-04-21 16:32 ` Jeff Hostetler 2022-05-06 12:43 ` Teng Long 2022-05-10 20:47 ` Jeff Hostetler 2022-04-21 13:26 ` [PATCH v2 5/5] pack-bitmap.c: using error() instead of silently returning -1 Teng Long 2022-04-21 15:41 ` Ævar Arnfjörð Bjarmason 2022-05-06 12:55 ` Teng Long 2022-06-12 7:44 ` [PATCH v3 0/5] Teng Long 2022-06-12 7:44 ` [PATCH v3 1/5] pack-bitmap.c: continue looping when first MIDX bitmap is found Teng Long 2022-06-12 7:44 ` [PATCH v3 2/5] pack-bitmap.c: rename "idx_name" to "bitmap_name" Teng Long 2022-06-12 7:44 ` [PATCH v3 3/5] pack-bitmap.c: make warnings support i18N when opening bitmap Teng Long 2022-06-12 7:44 ` [PATCH v3 4/5] pack-bitmap.c: using error() instead of silently returning -1 Teng Long 2022-06-14 1:15 ` Taylor Blau 2022-06-20 13:17 ` Teng Long 2022-06-12 7:44 ` [PATCH v3 5/5] bitmap: add trace2 outputs during open "bitmap" file Teng Long 2022-06-13 20:59 ` Junio C Hamano 2022-06-20 13:32 ` Teng Long 2022-06-14 1:40 ` Taylor Blau 2022-06-21 6:58 ` Teng Long 2022-06-22 12:51 ` Jeff Hostetler 2022-06-23 9:38 ` Teng Long 2022-06-23 15:14 ` Jeff Hostetler 2022-06-24 8:27 ` [PATCH v3 5/5] bitmap: add trace2 outputs during open "bitmap" Teng Long 2022-06-21 13:25 ` [PATCH v3 0/5] trace2 output for bitmap decision path Teng Long 2022-06-21 13:25 ` [PATCH v3 1/5] pack-bitmap.c: continue looping when first MIDX bitmap is found Teng Long 2022-06-21 13:25 ` [PATCH v3 2/5] pack-bitmap.c: rename "idx_name" to "bitmap_name" Teng Long 2022-06-21 13:25 ` [PATCH v3 3/5] pack-bitmap.c: make warnings support i18N when opening bitmap Teng Long 2022-06-21 13:25 ` [PATCH v3 4/5] pack-bitmap.c: using error() instead of silently returning -1 Teng Long 2022-06-21 13:25 ` [PATCH v3 5/5] bitmap: add trace2 outputs during open "bitmap" file Teng Long 2022-06-22 13:04 ` Jeff Hostetler 2022-06-22 15:12 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1bfd2fb6ab01af689fc6495e2f32d3f64c19f4b7.1650547400.git.dyroneteng@gmail.com \ --to=dyroneteng@gmail.com \ --cc=avarab@gmail.com \ --cc=derrickstolee@github.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=me@ttaylorr.com \ --cc=tenglong.tl@alibaba-inc.com \ --subject='Re: [PATCH v2 1/5] pack-bitmap.c: continue looping when first MIDX bitmap is found' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).