From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 03D031F9FD for ; Wed, 17 Feb 2021 21:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232801AbhBQVuv (ORCPT ); Wed, 17 Feb 2021 16:50:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232006AbhBQVuP (ORCPT ); Wed, 17 Feb 2021 16:50:15 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C2B7C061794 for ; Wed, 17 Feb 2021 13:48:57 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id x4so5457956wmi.3 for ; Wed, 17 Feb 2021 13:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=ASF8+rFWzj6aUvWIsRo10Spu216IfvU7//f0qbC+iF8=; b=NoeVE7hASI9DVqekqwFBILs3qHhuB/Ehrx3MvNW/GUmJTcWMAXunjfjjyxIsxaRwgT XOnWSfB+NVcp6/yBzMBHkJHhYWBRDyJpY8dR8jQC9nRO9ooM5O09+0U99FHSFEIbn70z C+I3BFc4bSS0RMKyQ+VGq4n/8hl+4XlUwt9wRPtwzXNtq4lprbvXK6cf4V7UutDz/Aaa /2heQqV3gZha+357u7ebr8G9TQj7gjo8X6HnbXA1TcEZWtH59V+Cj5qaZc6r3uh+LZYN W+kklZJLqox6Ijxmk9d0fB7mpB4fF9JogMfgyP+EjSZoeEBw53qcCoMO/sXsvHqRPrPB tYGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=ASF8+rFWzj6aUvWIsRo10Spu216IfvU7//f0qbC+iF8=; b=sjte/eQN/wydgfhlwLstDvRDW74qsXhogO92JTrJ7Cd4+YTociH2Cu5y7K6M2FwNca /9o+wH3A7jaluSS48p4TE5oNy6gJ8yJOBbvI/ykqkxTNq9auPorLylqE5kHWDefpe5q5 Q5B3w91D3xe9aqVPNoR3Wj1MeLLbcNsWa7oezG/PR/0/1gZQo8WgVJk5fRNUQdXRIK/C fWMDP+3eBVXfmYU/RGaEahCBeydKxC59t0RlQQDkgyFVE2ToXp71vcZt5RDUrkCX1HQI /0kKQn7vyeJIEecCKdS/tu/cS1oWUxqduxhpByQbLu1enEqgXXNve53sGa7oMgJ1qBQ0 ZY7g== X-Gm-Message-State: AOAM533ElTN/NMeJ5+0lhkBN43UZ+o2OMYH9pl4Ell0+jXbYhLmpvvBv DWkq3Ib/TRU+T2AmRhARFHgHaKye0YA= X-Google-Smtp-Source: ABdhPJwUv5T4OtXO8BB+eWD76xzrn6RAXqM8aZyYMj/jijKUsCEW8zn8tAqdFWremYZI3L/hOUE40g== X-Received: by 2002:a1c:bb44:: with SMTP id l65mr718999wmf.86.1613598536281; Wed, 17 Feb 2021 13:48:56 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id u137sm4962049wmu.20.2021.02.17.13.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 13:48:56 -0800 (PST) Message-Id: <1bfa36409d0706d5e22703f80bf95dfa1a313a83.1613598529.git.gitgitgadget@gmail.com> In-Reply-To: References: From: "Jeff Hostetler via GitGitGadget" Date: Wed, 17 Feb 2021 21:48:45 +0000 Subject: [PATCH v4 09/12] unix-socket: disallow chdir() when creating unix domain sockets Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Jeff Hostetler , Jeff King , SZEDER =?UTF-8?Q?G=C3=A1bor?= , Johannes Schindelin , Jeff Hostetler , Jeff Hostetler Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Jeff Hostetler Calls to `chdir()` are dangerous in a multi-threaded context. If `unix_stream_listen()` or `unix_stream_connect()` is given a socket pathname that is too long to fit in a `sockaddr_un` structure, it will `chdir()` to the parent directory of the requested socket pathname, create the socket using a relative pathname, and then `chdir()` back. This is not thread-safe. Teach `unix_sockaddr_init()` to not allow calls to `chdir()` when this flag is set. Signed-off-by: Jeff Hostetler --- builtin/credential-cache.c | 2 +- unix-socket.c | 17 ++++++++++++----- unix-socket.h | 4 +++- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/builtin/credential-cache.c b/builtin/credential-cache.c index 9b3f70990597..76a6ba37223f 100644 --- a/builtin/credential-cache.c +++ b/builtin/credential-cache.c @@ -14,7 +14,7 @@ static int send_request(const char *socket, const struct strbuf *out) { int got_data = 0; - int fd = unix_stream_connect(socket); + int fd = unix_stream_connect(socket, 0); if (fd < 0) return -1; diff --git a/unix-socket.c b/unix-socket.c index 5ac7dafe9828..1eaa8cf759c0 100644 --- a/unix-socket.c +++ b/unix-socket.c @@ -28,16 +28,23 @@ static void unix_sockaddr_cleanup(struct unix_sockaddr_context *ctx) } static int unix_sockaddr_init(struct sockaddr_un *sa, const char *path, - struct unix_sockaddr_context *ctx) + struct unix_sockaddr_context *ctx, + int disallow_chdir) { int size = strlen(path) + 1; ctx->orig_dir = NULL; if (size > sizeof(sa->sun_path)) { - const char *slash = find_last_dir_sep(path); + const char *slash; const char *dir; struct strbuf cwd = STRBUF_INIT; + if (disallow_chdir) { + errno = ENAMETOOLONG; + return -1; + } + + slash = find_last_dir_sep(path); if (!slash) { errno = ENAMETOOLONG; return -1; @@ -63,13 +70,13 @@ static int unix_sockaddr_init(struct sockaddr_un *sa, const char *path, return 0; } -int unix_stream_connect(const char *path) +int unix_stream_connect(const char *path, int disallow_chdir) { int fd = -1, saved_errno; struct sockaddr_un sa; struct unix_sockaddr_context ctx; - if (unix_sockaddr_init(&sa, path, &ctx) < 0) + if (unix_sockaddr_init(&sa, path, &ctx, disallow_chdir) < 0) return -1; fd = socket(AF_UNIX, SOCK_STREAM, 0); if (fd < 0) @@ -99,7 +106,7 @@ int unix_stream_listen(const char *path, unlink(path); - if (unix_sockaddr_init(&sa, path, &ctx) < 0) + if (unix_sockaddr_init(&sa, path, &ctx, opts->disallow_chdir) < 0) return -1; fd = socket(AF_UNIX, SOCK_STREAM, 0); if (fd < 0) diff --git a/unix-socket.h b/unix-socket.h index 06a5a05b03fe..2c0b2e79d7b3 100644 --- a/unix-socket.h +++ b/unix-socket.h @@ -3,6 +3,7 @@ struct unix_stream_listen_opts { int listen_backlog_size; + unsigned int disallow_chdir:1; }; #define DEFAULT_UNIX_STREAM_LISTEN_BACKLOG (5) @@ -10,9 +11,10 @@ struct unix_stream_listen_opts { #define UNIX_STREAM_LISTEN_OPTS_INIT \ { \ .listen_backlog_size = DEFAULT_UNIX_STREAM_LISTEN_BACKLOG, \ + .disallow_chdir = 0, \ } -int unix_stream_connect(const char *path); +int unix_stream_connect(const char *path, int disallow_chdir); int unix_stream_listen(const char *path, const struct unix_stream_listen_opts *opts); -- gitgitgadget