From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id D7071202A5 for ; Thu, 21 Sep 2017 19:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbdIUTCr (ORCPT ); Thu, 21 Sep 2017 15:02:47 -0400 Received: from avasout07.plus.net ([84.93.230.235]:38080 "EHLO avasout07.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbdIUTCr (ORCPT ); Thu, 21 Sep 2017 15:02:47 -0400 Received: from [10.0.2.15] ([147.147.86.16]) by avasout07 with smtp id CK2k1w0080M91Ur01K2lEh; Thu, 21 Sep 2017 20:02:46 +0100 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.2 cv=CrLPSjwD c=1 sm=1 tr=0 a=dubYQqM3tRRTmV8xSh8cXQ==:117 a=dubYQqM3tRRTmV8xSh8cXQ==:17 a=IkcTkHD0fZMA:10 a=EBOSESyhAAAA:8 a=XIIlD9B56uzOZumBWPgA:9 a=QEXdDO2ut3YA:10 a=yJM6EZoI5SlJf8ks9Ge_:22 X-AUTH: ramsayjones@:2500 Subject: Re: [PATCH 1/4] git-compat-util.h: xsize_t() - avoid -Wsign-compare warnings To: =?UTF-8?Q?Torsten_B=c3=b6gershausen?= , Junio C Hamano Cc: Jeff King , GIT Mailing-list References: <15367a04-754c-f6b8-a89b-2c1ff65dedf5@ramsayjones.plus.com> <75416139-74c5-8a60-22e8-79c53dd062c1@web.de> From: Ramsay Jones Message-ID: <1b778d3b-56d5-4cda-1b75-b0e81e19874e@ramsayjones.plus.com> Date: Thu, 21 Sep 2017 20:02:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <75416139-74c5-8a60-22e8-79c53dd062c1@web.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 21/09/17 19:49, Torsten Bögershausen wrote: > On 2017-09-21 18:46, Ramsay Jones wrote: >> >> Signed-off-by: Ramsay Jones >> --- >> git-compat-util.h | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/git-compat-util.h b/git-compat-util.h >> index 9bc15b036..cedad4d58 100644 >> --- a/git-compat-util.h >> +++ b/git-compat-util.h >> @@ -898,9 +898,11 @@ static inline char *xstrdup_or_null(const char *str) >> >> static inline size_t xsize_t(off_t len) >> { >> - if (len > (size_t) len) >> + size_t size = (size_t) len; >> + >> + if (len != (off_t) size) >> die("Cannot handle files this big"); >> - return (size_t)len; >> + return size; > > Hm, can someone help me out ? > Why is the cast not needed ? The cast in the return statement? If so, because the 'size' variable has been declared with the size_t type. (The truncation, if any, would happen when 'size' is initialised in the declaration). Hope that helps. ATB, Ramsay Jones