From: "Carlos Rica" <jasampler@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Function for updating refs.
Date: Wed, 5 Sep 2007 14:03:50 +0200 [thread overview]
Message-ID: <1b46aba20709050503r6027ada3u79ca8f5cb662775f@mail.gmail.com> (raw)
In-Reply-To: <7vy7flk2z5.fsf@gitster.siamese.dyndns.org>
2007/9/5, Junio C Hamano <gitster@pobox.com>:
> Carlos Rica <jasampler@gmail.com> writes:
> > - snprintf(msg, sizeof(msg), "%s: %s", rla, action);
> > - lock = lock_any_ref_for_update(refname, oldval, 0);
> > - if (!lock)
> > - return 1;
> > - if (write_ref_sha1(lock, sha1, msg) < 0)
> > - return 1;
> > - return 0;
> > + if (snprintf(msg, sizeof(msg), "%s: %s", rla, action) >= sizeof(msg))
> > + error("reflog message too long: %.*s...", 50, msg);
>
> The original I did was sloppy and did not detect this situation;
> thanks for fixing it. You do not refuse the primary operation,
> which is to update the ref, so this should be a warning instead
> of an error, I think.
Yes, it is. Also, I tested what would happen when the lock fails. I tried to
lock an already locked ref, and it died printing the message
die("unable to create '%s.lock': %s", path, strerror(errno)); from
lockfile.c. I think this is interesting. There are other failing
reasons that could
make the update_ref function to print its error, but I haven't tested them.
> > diff --git a/send-pack.c b/send-pack.c
> > ...
> This removal makes "struct ref_lock *lock" (not shown in the
> context) unused. I will remove the declaration.
Thank you. Also in builtin-update-ref.c the main function could return
directly that value returned from the call to update_ref().
prev parent reply other threads:[~2007-09-05 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 1:38 [PATCH] Function for updating refs Carlos Rica
2007-09-05 7:04 ` Junio C Hamano
2007-09-05 12:03 ` Carlos Rica [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b46aba20709050503r6027ada3u79ca8f5cb662775f@mail.gmail.com \
--to=jasampler@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).