From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Rafael Ascensão" <rafa.almas@gmail.com>,
git@vger.kernel.org, me@ikke.info, hjemli@gmail.com,
pclouds@gmail.com, ilari.liusvaara@elisanet.fi
Subject: Re: [PATCH v1 1/2] refs: extract function to normalize partial refs
Date: Mon, 6 Nov 2017 08:00:29 +0100 [thread overview]
Message-ID: <1ae0c199-f0fe-4468-1481-c7217ef6cc11@alum.mit.edu> (raw)
In-Reply-To: <xmqqwp34jj3h.fsf@gitster.mtv.corp.google.com>
On 11/06/2017 02:23 AM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> [1] I say "almost entirely" because putting them in one function means
>> that only `pattern` needs to be scanned for glob characters. But that is
>> an unimportant detail.
>
> That could actually be an important detail, in that even if prefix
> has wildcard, we'd still append the trailing "/*" as long as the
> pattern does not, right?
That's correct, but I was assuming that the prefix would always be a
hard-coded string like "refs/tags/" or maybe "refs/". (That is the case
now.) It doesn't seem very useful to use a prefix like "refs/*/".
Michael
next prev parent reply other threads:[~2017-11-06 7:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 0:41 [PATCH v1 0/2] Add option to git log to choose which refs receive decoration Rafael Ascensão
2017-11-04 0:41 ` [PATCH v1 1/2] refs: extract function to normalize partial refs Rafael Ascensão
2017-11-04 2:27 ` Junio C Hamano
2017-11-04 7:33 ` Rafael Ascensão
2017-11-04 22:45 ` Kevin Daudt
2017-11-05 13:21 ` Michael Haggerty
2017-11-05 13:42 ` Michael Haggerty
2017-11-06 1:23 ` Junio C Hamano
2017-11-06 2:37 ` Rafael Ascensão
2017-11-06 7:00 ` Michael Haggerty [this message]
2017-11-04 0:41 ` [PATCH v1 2/2] log: add option to choose which refs to decorate Rafael Ascensão
2017-11-04 3:49 ` Junio C Hamano
2017-11-04 7:34 ` Rafael Ascensão
2017-11-05 2:00 ` Junio C Hamano
2017-11-05 6:17 ` Junio C Hamano
2017-11-06 3:24 ` Rafael Ascensão
2017-11-06 3:51 ` Junio C Hamano
2017-11-06 7:09 ` Michael Haggerty
2017-11-06 20:10 ` Jacob Keller
2017-11-07 0:18 ` Junio C Hamano
2017-11-10 13:38 ` Rafael Ascensão
2017-11-10 17:42 ` Junio C Hamano
2017-11-21 21:33 ` [PATCH v2] " Rafael Ascensão
2017-11-22 4:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae0c199-f0fe-4468-1481-c7217ef6cc11@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=me@ikke.info \
--cc=pclouds@gmail.com \
--cc=rafa.almas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).