From: Andrey Okoshkin <a.okoshkin@samsung.com>
To: Jeff King <peff@peff.net>
Cc: gitster@pobox.com, git@vger.kernel.org, pclouds@gmail.com,
l.s.r@web.de, avarab@gmail.com, krh@redhat.com,
rctay89@gmail.com, Ivan Arishchenko <i.arishchenk@samsung.com>,
Mikhail Labiuk <m.labiuk@samsung.com>
Subject: Re: [PATCH v2] commit: check result of resolve_ref_unsafe
Date: Fri, 20 Oct 2017 13:40:40 +0300 [thread overview]
Message-ID: <19dc9ff5-54f3-290a-2dc8-c0be8e4047eb@samsung.com> (raw)
In-Reply-To: <20171019174452.hd3c47ocducddvgr@sigill.intra.peff.net>
19.10.2017 20:44, Jeff King wrote:
> On Thu, Oct 19, 2017 at 12:36:50PM +0300, Andrey Okoshkin wrote:
>
> Thanks, this looks good to me. One other possible minor improvement:
>
>> head = resolve_ref_unsafe("HEAD", 0, junk_oid.hash, NULL);
>> + if (!head)
>> + die(_("unable to resolve HEAD after creating commit"));
>
> Should we use die_errno() here to report the value of errno? I think
> resolve_ref_unsafe() should set it consistently (even an internal
> problem, like an illegally-formatted refname, yields EINVAL).
Thanks, sounds relevant.
Also as an alternative solution it's possible to use warning_errno
(instead of die_errno) and continue with 'head' set to something like
'unreadable|bad HEAD'.
> I grepped the code base looking for other instances of the same problem,
> and found four of them. Patches to follow.
>
> Unlike this one, I ended up quietly returning an error in most cases.
> The individual commit messages discuss the reasoning for each case, but
> I do wonder if we ought to simply die() in each case out of an abundance
> of caution (either the repo has a broken symref, or some weird
> filesystem error occurred, but either way it may be best not to
> continue). I dunno.
>
> These are all independent, so can be applied in any order or combination
> with respect to each other and to your patch.
>
> [1/4]: test-ref-store: avoid passing NULL to printf
> [2/4]: remote: handle broken symrefs
> [3/4]: log: handle broken HEAD in decoration check
> [4/4]: worktree: handle broken symrefs in find_shared_symref()
Good changes, it's better to apply.
--
Best regards,
Andrey
next prev parent reply other threads:[~2017-10-20 10:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171018170047epcas2p4310be357e11e194d6d08ac3bdc478ba3@epcas2p4.samsung.com>
2017-10-18 17:00 ` [PATCH] commit: check result of resolve_ref_unsafe Andrey Okoshkin
2017-10-18 18:34 ` Jeff King
2017-10-19 0:41 ` Junio C Hamano
2017-10-19 2:49 ` Jeff King
2017-10-19 9:33 ` Andrey Okoshkin
2017-10-19 9:36 ` [PATCH v2] " Andrey Okoshkin
2017-10-19 17:44 ` Jeff King
2017-10-19 17:46 ` [PATCH 1/4] test-ref-store: avoid passing NULL to printf Jeff King
2017-10-19 17:47 ` [PATCH 2/4] remote: handle broken symrefs Jeff King
2017-10-19 17:53 ` Jeff King
2017-10-19 17:49 ` [PATCH 3/4] log: handle broken HEAD in decoration check Jeff King
2017-10-19 17:49 ` [PATCH 4/4] worktree: handle broken symrefs in find_shared_symref() Jeff King
2017-10-21 10:49 ` Eric Sunshine
2017-10-21 19:26 ` Jeff King
2017-10-22 0:46 ` Junio C Hamano
2017-10-20 10:40 ` Andrey Okoshkin [this message]
2017-10-20 11:03 ` [PATCH v3] commit: check result of resolve_ref_unsafe Andrey Okoshkin
2017-10-20 13:09 ` [PATCH v4] " Andrey Okoshkin
2017-10-21 6:19 ` Jeff King
2017-10-22 0:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19dc9ff5-54f3-290a-2dc8-c0be8e4047eb@samsung.com \
--to=a.okoshkin@samsung.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=i.arishchenk@samsung.com \
--cc=krh@redhat.com \
--cc=l.s.r@web.de \
--cc=m.labiuk@samsung.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).