From: "Philip Oakley" <philipoakley@iee.org>
To: "Git List" <git@vger.kernel.org>
Cc: "Duy" <pclouds@gmail.com>
Subject: /* compiler workaround */ - what was the issue?
Date: Thu, 5 May 2016 21:48:40 +0100 [thread overview]
Message-ID: <17E04501C9474282B87758C7998A1F5B@PhilipOakley> (raw)
In-Reply-To: AA5B2B1715BAF7438221293187A417A7BDE9D11D@desmdswms002.des.grplnk.net
Duy,
In
https://github.com/git-for-windows/git/commit/b3c96fb158f05152336f167076f5d81d23c3a5e5
(split-index: strip pathname of on-disk replaced entries, 13 Jun 2014)
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> you have
read-cache.c#L1790 (in that commit, now ~L1873)
int saved_namelen = saved_namelen; /* compiler workaround */
Which then becomes an MSVC compile warning C4700: uninitialized local
variable.
I'm wondering what was the compiler workaround being referred to? i.e. why
does it need that tweak? There's no mention of the reason in the commit
message.
There are a few other occurences of this same initialisation issue, so I was
wondering if it's still neded? Or should I just get MSVC to ignore it, which
may hide other issues..
--
Philip
next parent reply other threads:[~2016-05-05 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AA5B2B1715BAF7438221293187A417A7BDE9D11D@desmdswms002.des.grplnk.net>
2016-05-05 20:48 ` Philip Oakley [this message]
2016-05-05 21:41 ` /* compiler workaround */ - what was the issue? Junio C Hamano
2016-05-06 10:17 ` Duy Nguyen
2016-05-06 13:15 ` Philip Oakley
2016-05-06 18:05 ` Ramsay Jones
2016-05-06 18:33 ` Philip Oakley
2016-05-06 18:54 ` Junio C Hamano
2016-05-06 19:30 ` Marc Branchaud
2016-05-06 19:57 ` Junio C Hamano
2016-05-06 20:01 ` Stefan Beller
2016-05-09 19:40 ` Philip Oakley
2016-05-09 19:49 ` Randall S. Becker
2016-05-06 20:28 ` Marc Branchaud
2016-05-06 20:21 ` Ramsay Jones
2016-05-06 21:17 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17E04501C9474282B87758C7998A1F5B@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).