git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Hariom Verma <hariom18599@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Hariom Verma <hariom18599@gmail.com>
Subject: [PATCH 1/1] git-compat-util.h: drop the `PRIuMAX` definition
Date: Sun, 24 Nov 2019 13:09:23 +0000	[thread overview]
Message-ID: <177deddcf83c2550c0db536a7a6942ba69a92fa5.1574600963.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.473.git.1574600963.gitgitgadget@gmail.com>

From: Hariom Verma <hariom18599@gmail.com>

Git's code base already seems to be using `PRIdMAX` without any such
fallback definition for quite a while (75459410edd (json_writer: new
routines to create JSON data, 2018-07-13), to be precise, and the
first Git version to include that commit was v2.19.0).

Therefore it should be safe to drop the fallback definition for
`PRIuMAX` in `git-compat-util.h`.

This addresses https://github.com/gitgitgadget/git/issues/399

Signed-off-by: Hariom Verma <hariom18599@gmail.com>
---
 git-compat-util.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/git-compat-util.h b/git-compat-util.h
index 607dca7534..ba710cfa6c 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -320,10 +320,6 @@ char *gitdirname(char *);
 #define PATH_MAX 4096
 #endif
 
-#ifndef PRIuMAX
-#define PRIuMAX "llu"
-#endif
-
 #ifndef SCNuMAX
 #define SCNuMAX PRIuMAX
 #endif
-- 
gitgitgadget

  reply	other threads:[~2019-11-24 13:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 13:09 [PATCH 0/1] git-compat-util.h: drop the PRIuMAX definition Hariom Verma via GitGitGadget
2019-11-24 13:09 ` Hariom Verma via GitGitGadget [this message]
2019-11-24 17:06   ` [PATCH 1/1] git-compat-util.h: drop the `PRIuMAX` definition Jeff King
2019-11-24 17:40     ` Carlo Arenas
2019-11-24 20:15       ` Carlo Arenas
2019-11-25  2:24     ` Junio C Hamano
2019-11-25  2:45       ` Junio C Hamano
2019-11-25  9:34         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177deddcf83c2550c0db536a7a6942ba69a92fa5.1574600963.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hariom18599@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).