From: Paul Mackerras <paulus@samba.org>
To: Pavel Roskin <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: gitk changing line color for no reason after merge
Date: Tue, 7 Feb 2006 19:56:48 +1100 [thread overview]
Message-ID: <17384.24784.898327.669875@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1139289517.15955.23.camel@dv>
Pavel Roskin writes:
> Hello!
> I didn't realize that the colors correspond to nodes, not branches.
> Every node has one color that is used for lines to all of its children.
> It would be much better to assign colors to "branches" consisting of
> individual lines connecting nodes, but changing that would require many
Why would that be better?
> > - if {$nparents($id) <= 1 && $nchildren($id) == 1} {
> > + if {$nchildren($id) == 1} {
> > set child [lindex $children($id) 0]
> > if {[info exists colormap($child)]
> > && $nparents($child) == 1} {
> >
> >
>
> I still stand behind this patch because it eliminates color changes on
> the nodes that have exactly one child and parent. $nparents($id) is
Ummm... I don't see that you have changed anything for nodes that have
exactly one parent?
> However, further changes to reduce color changes didn't produce nice
> results for me. If I try to keep one color running as long as possible,
> I get branches of the same color because, as I said, gitk uses the same
> color for connections to all children. So, every node on the branch
> spurs branching lines of the same color, which can intersect or run
> side-by-side.
The colors are really just to make the lines visually distinct. They
(the colors) have no semantic meaning. (I did try coloring the lines
according to the committer, but I just ended up with an awful lot of
lines being the same color - corresponding to one Linus Torvalds. :)
Paul.
next prev parent reply other threads:[~2006-02-07 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 17:21 gitk changing line color for no reason after merge Pavel Roskin
2006-02-07 5:18 ` Pavel Roskin
2006-02-07 8:56 ` Paul Mackerras [this message]
2006-02-08 1:10 ` Pavel Roskin
2006-02-07 10:04 ` Junio C Hamano
2006-02-08 0:54 ` Pavel Roskin
2006-02-08 2:30 ` Paul Mackerras
2006-02-08 21:06 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17384.24784.898327.669875@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).