From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 11EBE208B4 for ; Thu, 10 Aug 2017 21:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbdHJVFe (ORCPT ); Thu, 10 Aug 2017 17:05:34 -0400 Received: from hapkido.dreamhost.com ([66.33.216.122]:34834 "EHLO hapkido.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099AbdHJVFd (ORCPT ); Thu, 10 Aug 2017 17:05:33 -0400 X-Greylist: delayed 43456 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Aug 2017 17:05:33 EDT Received: from homiemail-a111.g.dreamhost.com (sub4.mail.dreamhost.com [69.163.253.135]) by hapkido.dreamhost.com (Postfix) with ESMTP id 502DE8E439 for ; Thu, 10 Aug 2017 02:01:17 -0700 (PDT) Received: from homiemail-a111.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a111.g.dreamhost.com (Postfix) with ESMTP id AE7133C001C17; Thu, 10 Aug 2017 02:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jupiterrise.com; h=subject :to:cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=jupiterrise.com; bh=B /xfqx0ADa0lhqaH7ym3eheOKsA=; b=w+zz0QoNRM+/sYa5dEBaBtoIPy3+Q8C7y tGCzPyDOv07r+EEszOlw+hs4yS0tJzUwWklTQ6XaI8NgcP5R/tuxB4PRBGmrDHK7 hHthK6SlsPcSE2gVISiPl0rqK0dGOpxPPc5Zk4XaVJwraY3xhslzHXwFDToO4wmj YprYf18GHg= Received: from merlin.tgcnet.jupiterrise.com (2-106-159-182-static.dk.customer.tdc.net [2.106.159.182]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tgc99@jupiterrise.com) by homiemail-a111.g.dreamhost.com (Postfix) with ESMTPSA id 7B39C3C001C15; Thu, 10 Aug 2017 02:01:16 -0700 (PDT) Received: from odin.tgcnet.jupiterrise.com (router.tgcnet.jupiterrise.com [192.168.20.58]) by merlin.tgcnet.jupiterrise.com (Postfix) with ESMTPSA id 1CA84605EE; Thu, 10 Aug 2017 11:01:14 +0200 (CEST) Received: from [IPv6:::1] (localhost [IPv6:::1]) by odin.tgcnet.jupiterrise.com (Postfix) with ESMTP id AFB62E80554; Thu, 10 Aug 2017 11:01:12 +0200 (CEST) Subject: Re: [PATCH 0/4] dropping support for older curl To: Jeff King , Johannes Schindelin Cc: git@vger.kernel.org References: <20170809120024.7phdjzjv54uv5dpz@sigill.intra.peff.net> <20170809214758.p77fqrwxanb4zn5a@sigill.intra.peff.net> From: "Tom G. Christensen" Message-ID: <171c1316-1f52-57e3-10ea-e0b0817967e8@jupiterrise.com> Date: Thu, 10 Aug 2017 11:01:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170809214758.p77fqrwxanb4zn5a@sigill.intra.peff.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GH Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 09/08/17 23:47, Jeff King wrote: > On Wed, Aug 09, 2017 at 11:42:12PM +0200, Johannes Schindelin wrote: >> I mean, if we even go out of our way to support the completely outdated >> and obsolete .git/branches/ for what is likely a single user, it may not >> be the worst to keep those couple of #ifdef guards to keep at least >> nominal support for older cURLs? > > You've totally ignored the argument I made back then[1], and which I > reiterated in this thread. So I'll say it one more time: the more > compelling reason is not the #ifdefs, but the fact that the older > versions are totally untested. Perhaps you forgot but I stated in the original thread that I build RPMS for RHEL/CentOS 3, 4, 5, 6 and 7. I still do and I run the testsuite every single time. I currently have 2.13.3 up for el4, el5, el6 and el7. Only el4 requires any patches, the rest will build out of the box with the vendor supplied version of curl. The plan was to drop the el4 builds for 2.14.0 to get rid of the patches. > In fact, they do not even compile, and > yet I have not seen any patches to fix that. > I just built a pristine 2.14.0 on CentOS 5 with curl 7.15.5. No problems at all neither with building nor with running the testsuite. > So IMHO this is about being honest with users about which versions we > _actually_ support. > I have no problem with you wanting to drop support for older curl releases (such as 7.15.5) but don't use the argument that it doesn't currently build and nobody cares. Also FWIW Red Hat continues to support RHEL 5 with the Extended Life-cycle Support program until 2020-11-30. -tgc