From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
To: Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>
Cc: git@vger.kernel.org,
Remi Galan <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v5 07/10] send-email: reduce dependancies impact on parse_address_line
Date: Sun, 21 Jun 2015 12:07:36 +0200 (CEST) [thread overview]
Message-ID: <1692637261.3463890.1434881256090.JavaMail.zimbra@imag.fr> (raw)
In-Reply-To: <1434842273-30945-7-git-send-email-remi.lespinet@ensimag.grenoble-inp.fr>
This is the last message I received in the series, and it's labeled 07/10. Is that normal?
> parse_address_line had not the same behavior whether the user had
had not -> did not have
> I've added the function in Git.pm as suggested. I've also added a test
> named t9000-addresses.sh (I've read the README to name tests but I'm
> not sure about the name of this test). I made a separated test
> (t9000-addresses.sh) because I think it's better not to pollute
> t9001-send-email with this.
Sounds good to me.
> About the test itself, file t/t9000-addresses.sh is just a copy/paste
> of t/t0202-gettext-perl.sh. For the perl part, the TODO tests are
> verbose: they print out commands whereas test_expect_success doesn't.
It seems it's how Test::More works. I'd keep it like this, but I have no real experience with Test::More.
> We can redirect todo_output to a variable but I've not found better...
> (Maybe someone has the solution here ?). Also there's no summary at
> the end of the test (as with other perl tests).
You can get the 1..44 at the end with
printf "1..%d\n", Test::More->builder->current_test;
This is what t9700/test.pl does.
> diff --git a/perl/Git.pm b/perl/Git.pm
> index 9026a7b..97633e9 100644
> --- a/perl/Git.pm
> +++ b/perl/Git.pm
> @@ -1584,6 +1584,73 @@ sub DESTROY {
> $self->_close_cat_blob();
> }
>
> +=item parse_mailboxes
> +
> +Returns an array of mailboxes extracted from a string.
Imperative tone => Return, not Returns.
I would have put parse_mailbox near ident_person because both functions are somehow about email.
> +BEGIN { use_ok('Git') }
> +BEGIN { use_ok('Mail::Address') }
This will fail if Mail::Address is not available. It would be better to declare Mail::Address as a prerequisite in t9000-address.sh (like what you're already doing for Test::More).
Good job, modulo these minor details, the series looks good to me.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-21 10:07 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 14:18 [PATCH/RFC v4 01/10] t9001-send-email: move script creation in a setup test Remi Lespinet
2015-06-17 14:18 ` [PATCH/RFC v4 02/10] send-email: allow aliases in patch header and command script outputs Remi Lespinet
2015-06-17 14:18 ` [PATCH/RFC v4 03/10] t9001-send-email: refactor header variable fields replacement Remi Lespinet
2015-06-17 14:18 ` [PATCH/RFC v4 04/10] send-email: refactor address list process Remi Lespinet
2015-06-17 14:18 ` [PATCH/RFC v4 05/10] send-email: Allow use of aliases in the From field of --compose mode Remi Lespinet
2015-06-17 15:57 ` Matthieu Moy
2015-06-17 14:18 ` [PATCH/RFC v4 06/10] send-email: minor code refactoring Remi Lespinet
2015-06-17 14:18 ` [PATCH/RFC v4 07/10] send-email: reduce dependancies impact on parse_address_line Remi Lespinet
2015-06-17 15:45 ` Matthieu Moy
2015-06-17 23:39 ` Remi Lespinet
2015-06-17 21:27 ` Junio C Hamano
2015-06-17 23:48 ` Remi Lespinet
2015-06-18 11:39 ` Matthieu Moy
2015-06-18 15:08 ` Remi Lespinet
2015-06-18 17:29 ` Matthieu Moy
2015-06-18 21:29 ` Remi Lespinet
2015-06-19 7:16 ` Matthieu Moy
2015-06-17 14:30 ` [PATCH/RFC v4 08/10] send-email: consider quote as delimiter instead of character Remi Lespinet
2015-06-17 14:31 ` [PATCH/RFC v4 09/10] send-email: allow multiple emails using --cc, --to and --bcc Remi Lespinet
2015-06-17 14:32 ` [PATCH/RFC v4 10/10] send-email: suppress meaningless whitespaces in from field Remi Lespinet
2015-06-17 14:54 ` Matthieu Moy
2015-06-17 15:11 ` Remi Lespinet
2015-06-20 23:17 ` [PATCH v5 01/10] t9001-send-email: move script creation in a setup test Remi Lespinet
2015-06-20 23:17 ` [PATCH v5 02/10] send-email: allow aliases in patch header and command script outputs Remi Lespinet
2015-06-20 23:17 ` [PATCH v5 03/10] t9001-send-email: refactor header variable fields replacement Remi Lespinet
2015-06-20 23:17 ` [PATCH v5 04/10] send-email: refactor address list process Remi Lespinet
2015-06-20 23:17 ` [PATCH v5 05/10] send-email: Allow use of aliases in the From field of --compose mode Remi Lespinet
2015-06-20 23:17 ` [PATCH v5 06/10] send-email: minor code refactoring Remi Lespinet
2015-06-20 23:17 ` [PATCH v5 07/10] send-email: reduce dependancies impact on parse_address_line Remi Lespinet
2015-06-21 10:07 ` Matthieu Moy [this message]
2015-06-21 13:02 ` Remi Lespinet
2015-06-23 20:15 ` Remi Lespinet
2015-06-21 13:24 ` Matthieu Moy
2015-06-21 12:45 ` [PATCH v5 08/10] send-email: consider quote as delimiter instead of character Remi Lespinet
2015-06-21 12:45 ` [PATCH v5 09/10] send-email: allow multiple emails using --cc, --to and --bcc Remi Lespinet
2015-06-21 13:17 ` Matthieu Moy
2015-06-21 12:45 ` [PATCH v5 10/10] send-email: suppress meaningless whitespaces in from field Remi Lespinet
2015-06-23 20:30 ` [PATCH v6 01/10] t9001-send-email: move script creation in a setup test Remi Lespinet
2015-06-23 20:30 ` [PATCH v6 02/10] send-email: allow aliases in patch header and command script outputs Remi Lespinet
2015-06-23 20:30 ` [PATCH v6 03/10] t9001-send-email: refactor header variable fields replacement Remi Lespinet
2015-06-23 20:30 ` [PATCH v6 04/10] send-email: refactor address list process Remi Lespinet
2015-06-23 20:30 ` [PATCH v6 05/10] send-email: Allow use of aliases in the From field of --compose mode Remi Lespinet
2015-06-23 20:30 ` [PATCH v6 06/10] send-email: minor code refactoring Remi Lespinet
2015-06-23 20:30 ` [PATCH v6 07/10] send-email: reduce dependencies impact on parse_address_line Remi Lespinet
2015-06-23 20:39 ` Matthieu Moy
2015-06-23 20:58 ` Remi LESPINET
2015-06-23 20:40 ` [PATCH v6 08/10] send-email: consider quote as delimiter instead of character Remi Lespinet
2015-06-23 20:41 ` [PATCH v6 09/10] send-email: allow multiple emails using --cc, --to and --bcc Remi Lespinet
2015-06-23 20:44 ` Matthieu Moy
2015-06-23 20:41 ` [PATCH v6 10/10] send-email: suppress meaningless whitespaces in from field Remi Lespinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1692637261.3463890.1434881256090.JavaMail.zimbra@imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).