git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Shanthanu <shanthanu.s.rai9@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [GSoC] Query regarding Microproject
Date: Wed, 25 Mar 2020 19:21:58 +0530	[thread overview]
Message-ID: <165cc039-2092-2520-e23e-5734fd3fc0f8@gmail.com> (raw)
In-Reply-To: <CAP8UFD3fAQyiXsO0w_uG6Oe8EfvkL6=ijUqHp4j8GD8A50Jo+g@mail.gmail.com>


On 24/03/20 1:01 am, Christian Couder wrote:
>> So shouldn't the test file itself have mentioned (say as a comment at
>> the top
>> or in a separate README) that it was expecting subversion 1.8 or lesser on
>> the system? I am using Ubuntu 18.04 and by default the package manager
>> installs subversion 1.9.
> It would be better if the test could be fixed to work with subversion
> 1.9. Otherwise the test could perhaps check the subversion version and
> run only if subversion is version 1.8 or lesser.

Yeah that makes sense. I will try to look into how the tests can be
fixed to work with svn 1.9.

>> This issue might also be present in other git-svn test files. (I haven't
>> checked
>> though, not sure how to run just git-svn tests)
> Maybe with something like:
>
> $ cd t
> $ prove --jobs 8 t91*-svn*.sh

Thanks. I ran the command and found that all tests (except t9119) fail for
svn 1.9 and pass for 1.8.
t9119 gives the below output for svn 1.8:
skipped: skipping svn-info test (SVN version: 1.8.13 not supported)

't9119-git-svn-info.sh' seems to already have the code to check
the version of subversion. So we could use the same code to check
the correct version in 'lib-git-svn.sh'?

Note that I haven't checked which all subversion versions work for
a given test (only know that svn 1.8 works for all).


  reply	other threads:[~2020-03-25 13:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  6:37 [GSoC] Query regarding Microproject Shanthanu Rai
2020-03-20 13:41 ` Christian Couder
2020-03-20 16:27   ` Shanthanu
2020-03-21  9:49     ` Shanthanu
2020-03-23 19:31       ` Christian Couder
2020-03-25 13:51         ` Shanthanu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-03-05  8:05 [GSOC]:query regarding microproject Sushma Unnibhavi
2019-03-05 21:29 ` Thomas Gummerer
2019-03-04  5:26 [GSoC] Query " Umang Parmar
2019-03-04  7:41 ` Junio C Hamano
2019-03-04  7:52   ` Duy Nguyen
2019-03-04  9:05     ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165cc039-2092-2520-e23e-5734fd3fc0f8@gmail.com \
    --to=shanthanu.s.rai9@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).